( )⚙ D5932 branchmap: decode a label only once

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5932

branchmap: decode a label only once
ClosedPublic

Authored by pulkit on Feb 11 2019, 8:05 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG9d0d8793e847: branchmap: decode a label only once
Summary

This moves decoding of a label out of for loop. Minor speed up expected in cases
when one branch has multiple heads. For example: someone using bookmarks as
branches and hence ending up with multiple heads on default branch.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Feb 11 2019, 8:05 AM
Closed by commit rHG9d0d8793e847: branchmap: decode a label only once (authored by pulkit). · Explain WhyFeb 11 2019, 8:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/branchmap.py (4 lines)

Diff 14028

mercurial/branchmap.py

try: try:
f = repo.cachevfs(self._filename(repo), "w", atomictemp=True) f = repo.cachevfs(self._filename(repo), "w", atomictemp=True)
cachekey = [hex(self.tipnode), '%d' % self.tiprev] cachekey = [hex(self.tipnode), '%d' % self.tiprev]
if self.filteredhash is not None: if self.filteredhash is not None:
cachekey.append(hex(self.filteredhash)) cachekey.append(hex(self.filteredhash))
f.write(" ".join(cachekey) + '\n') f.write(" ".join(cachekey) + '\n')
nodecount = 0 nodecount = 0
for label, nodes in sorted(self.iteritems()): for label, nodes in sorted(self.iteritems()):
label = encoding.fromlocal(label)
for node in nodes: for node in nodes:
nodecount += 1 nodecount += 1
if node in self._closednodes: if node in self._closednodes:
state = 'c' state = 'c'
else: else:
state = 'o' state = 'o'
f.write("%s %s %s\n" % (hex(node), state, f.write("%s %s %s\n" % (hex(node), state, label))
encoding.fromlocal(label)))
f.close() f.close()
repo.ui.log('branchcache', repo.ui.log('branchcache',
'wrote %s branch cache with %d labels and %d nodes\n', 'wrote %s branch cache with %d labels and %d nodes\n',
repo.filtername, len(self), nodecount) repo.filtername, len(self), nodecount)
except (IOError, OSError, error.Abort) as inst: except (IOError, OSError, error.Abort) as inst:
# Abort may be raised by read only opener, so log and continue # Abort may be raised by read only opener, so log and continue
repo.ui.debug("couldn't write branch cache: %s\n" % repo.ui.debug("couldn't write branch cache: %s\n" %
stringutil.forcebytestr(inst)) stringutil.forcebytestr(inst))