This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5949

debugpathcopies: fix typo in synopsis
ClosedPublic

Authored by martinvonz on Feb 12 2019, 4:47 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG09814946cc6a: debugpathcopies: fix typo in synopsis
rHGb738093d4b8f: debugpathcopies: fix typo in synopsis
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Feb 12 2019, 4:47 PM
martinvonz added a comment.Feb 12 2019, 10:42 PM
In D5949#86905, @JordiGH wrote:

fix typo in synpsis
in synpsis
synpsis

https://en.wikipedia.org/wiki/Muphry%27s_law

Heh, I initially typo'ed "typo" as "typy", but I noticed that one. Impressive that I squeezed another typo in in those few words

JordiGH added a comment.Feb 12 2019, 10:44 PM

So, I haven't been here in a while. Do we still do V2s for this kind of thing?

martinvonz added a comment.Feb 12 2019, 10:49 PM
In D5949#86908, @JordiGH wrote:

So, I haven't been here in a while. Do we still do V2s for this kind of thing?

Often fixed in n flight. I'll still fix it later tonight if I remember.

martinvonz added a comment.Feb 12 2019, 10:52 PM
In D5949#86909, @martinvonz wrote:
In D5949#86908, @JordiGH wrote:

So, I haven't been here in a while. Do we still do V2s for this kind of thing?

Often fixed in n flight. I'll still fix it later tonight if I remember.

But to answer your question me generally: I think this kind of thing is usually ignored. I have seen so many of my own commit messages have typos and still get accepted (and I notice the typo later).

martinvonz retitled this revision from debugpathcopies: fix typo in synpsis to debugpathcopies: fix typo in synopsis.Feb 13 2019, 12:17 AM
Closed by commit rHGb738093d4b8f: debugpathcopies: fix typo in synopsis (authored by martinvonz). · Explain WhyFeb 13 2019, 7:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/debugcommands.py (2 lines)

Diff 14066

mercurial/debugcommands.py

files.update(f) files.update(f)
dirs.update(d) dirs.update(d)
files.update(dirs) files.update(dirs)
ui.write('\n'.join(repo.pathto(p, cwd) for p in sorted(files))) ui.write('\n'.join(repo.pathto(p, cwd) for p in sorted(files)))
ui.write('\n') ui.write('\n')
@command('debugpathcopies', @command('debugpathcopies',
cmdutil.walkopts, cmdutil.walkopts,
'hg debugcopies REV1 REV2 [FILE]', 'hg debugpathcopies REV1 REV2 [FILE]',
inferrepo=True) inferrepo=True)
def debugpathcopies(ui, repo, rev1, rev2, *pats, **opts): def debugpathcopies(ui, repo, rev1, rev2, *pats, **opts):
"""show copies between two revisions""" """show copies between two revisions"""
ctx1 = scmutil.revsingle(repo, rev1) ctx1 = scmutil.revsingle(repo, rev1)
ctx2 = scmutil.revsingle(repo, rev2) ctx2 = scmutil.revsingle(repo, rev2)
m = scmutil.match(ctx1, pats, opts) m = scmutil.match(ctx1, pats, opts)
for dst, src in copies.pathcopies(ctx1, ctx2, m).items(): for dst, src in copies.pathcopies(ctx1, ctx2, m).items():
ui.write('%s -> %s\n' % (src, dst)) ui.write('%s -> %s\n' % (src, dst))