This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5967

chistedit: improve proper username in histedit curses interface in changeset section (issue6072)
ClosedPublic

Authored by akshjain.jain74 on Feb 14 2019, 3:52 PM.

Details

Reviewers
durin42
martinvonz
Group Reviewers
hg-reviewers
Commits
rHGdf1f3ba56157: chistedit: improve proper username in histedit curses interface

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

akshjain.jain74 retitled this revision from curses: improve proper username in histedit curses interface in changeset section (issue6072) to chistedit: improve proper username in histedit curses interface in changeset section (issue6072).Feb 14 2019, 3:56 PM
martinvonz accepted this revision.Feb 14 2019, 4:22 PM
martinvonz added a subscriber: martinvonz.

Looks like there's plenty of space there to show the full username. I suspect it was the way it was because it came from FB where just the username is enough to identify people.

This revision is now accepted and ready to land.Feb 14 2019, 4:22 PM
Closed by commit rHGdf1f3ba56157: chistedit: improve proper username in histedit curses interface (authored by akshjain.jain74). · Explain WhyFeb 14 2019, 4:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/histedit.py (2 lines)

Diff 14098

hgext/histedit.py

win.box() win.box()
maxy, maxx = win.getmaxyx() maxy, maxx = win.getmaxyx()
length = maxx - 3 length = maxx - 3
line = "changeset: {0}:{1:<12}".format(ctx.rev(), ctx) line = "changeset: {0}:{1:<12}".format(ctx.rev(), ctx)
win.addstr(1, 1, line[:length]) win.addstr(1, 1, line[:length])
line = "user: {0}".format(stringutil.shortuser(ctx.user())) line = "user: {0}".format(ctx.user())
win.addstr(2, 1, line[:length]) win.addstr(2, 1, line[:length])
bms = repo.nodebookmarks(ctx.node()) bms = repo.nodebookmarks(ctx.node())
line = "bookmark: {0}".format(' '.join(bms)) line = "bookmark: {0}".format(' '.join(bms))
win.addstr(3, 1, line[:length]) win.addstr(3, 1, line[:length])
line = "files: {0}".format(','.join(ctx.files())) line = "files: {0}".format(','.join(ctx.files()))
win.addstr(4, 1, line[:length]) win.addstr(4, 1, line[:length])