This is an archive of the discontinued Mercurial Phabricator instance.

cmdutil: moving first use of newid closer to its use in amend
ClosedPublic

Authored by singhsrb on Aug 31 2017, 10:01 PM.

Details

Summary

newid was needlessly further away from where its intended to be used
leading to bad readability. This commit moves it to address the same. The end
goal is to remove the redundant commit in the amend code path and this commit
takes care of cleaning up some unrelated code before that change.

Test Plan

ran the test suite

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

singhsrb created this revision.Aug 31 2017, 10:01 PM

moving first use of newid closer to its use in amend

Changing this to "moving first *assignment* of..." in flight so it sounds less confusing.

Also, "cmdutil" is so large it doesn't add much, so I'm also replacing "cmdutil" by "amend" and dropping "in amend" in the summary lines.

This revision was automatically updated to reflect the committed changes.