This is an archive of the discontinued Mercurial Phabricator instance.

	Status	Author	Revision
	Closed	pulkit	D5296 store: don't read the whole fncache in memory
	Closed	pulkit	D6030 store: move logic to check for invalid entry in fncache to own function

Diff 14533

	self._dirty = False			self._dirty = False
	try:			try:
	fp = self.vfs('fncache', mode='rb')			fp = self.vfs('fncache', mode='rb')
	except IOError:			except IOError:
	# skip nonexistent file			# skip nonexistent file
	self.entries = set()			self.entries = set()
	return			return
	self.entries = set(decodedir(fp.read()).splitlines())			self.entries = set(decodedir(fp.read()).splitlines())
				self._checkentries(fp)
				fp.close()

				def _checkentries(self, fp):
				""" make sure there is no empty string in entries """
	if '' in self.entries:			if '' in self.entries:
	fp.seek(0)			fp.seek(0)
	for n, line in enumerate(util.iterfile(fp)):			for n, line in enumerate(util.iterfile(fp)):
	if not line.rstrip('\n'):			if not line.rstrip('\n'):
	t = _('invalid entry in fncache, line %d') % (n + 1)			t = _('invalid entry in fncache, line %d') % (n + 1)
	raise error.Abort(t)			raise error.Abort(t)
	fp.close()

	def write(self, tr):			def write(self, tr):
	if self._dirty:			if self._dirty:
	assert self.entries is not None			assert self.entries is not None
	self.entries = self.entries \| self.addls			self.entries = self.entries \| self.addls
	self.addls = set()			self.addls = set()
	tr.addbackup('fncache')			tr.addbackup('fncache')
	fp = self.vfs('fncache', mode='wb', atomictemp=True)			fp = self.vfs('fncache', mode='wb', atomictemp=True)