This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6031

py3: make contrib/debugshell.py work with Python 3
ClosedPublic

Authored by pulkit on Feb 27 2019, 5:46 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGb10bbbe995eb: py3: make contrib/debugshell.py work with Python 3
Summary

I changed default mercurial installation of my personal laptop to one installed
with python 3.7. debugshell is one of the extension which I have enabled and it
was failing. This patch makes debugshell works with Python 3.

I found that chg does not work with python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Feb 27 2019, 5:46 PM
Closed by commit rHGb10bbbe995eb: py3: make contrib/debugshell.py work with Python 3 (authored by pulkit). · Explain WhyFeb 27 2019, 8:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/debugshell.py (13 lines)

Diff 14267

contrib/debugshell.py

# debugshell extension # debugshell extension
"""a python shell with repo, changelog & manifest objects""" """a python shell with repo, changelog & manifest objects"""
from __future__ import absolute_import from __future__ import absolute_import
import code import code
import mercurial import mercurial
import sys import sys
from mercurial import ( from mercurial import (
demandimport, demandimport,
pycompat,
registrar, registrar,
) )
cmdtable = {} cmdtable = {}
command = registrar.command(cmdtable) command = registrar.command(cmdtable)
def pdb(ui, repo, msg, **opts): def pdb(ui, repo, msg, **opts):
objects = { objects = {
import IPython import IPython
cl = repo.changelog cl = repo.changelog
mf = repo.manifestlog mf = repo.manifestlog
cl, mf # use variables to appease pyflakes cl, mf # use variables to appease pyflakes
IPython.embed() IPython.embed()
@command('debugshell|dbsh', []) @command(b'debugshell|dbsh', [])
def debugshell(ui, repo, **opts): def debugshell(ui, repo, **opts):
bannermsg = ("loaded repo : %s\n" bannermsg = ("loaded repo : %s\n"
"using source: %s" % (repo.root, "using source: %s" % (pycompat.sysstr(repo.root),
mercurial.__path__[0])) mercurial.__path__[0]))
pdbmap = { pdbmap = {
'pdb' : 'code', 'pdb' : 'code',
'ipdb' : 'IPython' 'ipdb' : 'IPython'
} }
debugger = ui.config("ui", "debugger") debugger = ui.config(b"ui", b"debugger")
if not debugger: if not debugger:
debugger = 'pdb' debugger = 'pdb'
else:
debugger = pycompat.sysstr(debugger)
# if IPython doesn't exist, fallback to code.interact # if IPython doesn't exist, fallback to code.interact
try: try:
with demandimport.deactivated(): with demandimport.deactivated():
__import__(pdbmap[debugger]) __import__(pdbmap[debugger])
except ImportError: except ImportError:
ui.warn(("%s debugger specified but %s module was not found\n") ui.warn((b"%s debugger specified but %s module was not found\n")
% (debugger, pdbmap[debugger])) % (debugger, pdbmap[debugger]))
debugger = 'pdb' debugger = b'pdb'
getattr(sys.modules[__name__], debugger)(ui, repo, bannermsg, **opts) getattr(sys.modules[__name__], debugger)(ui, repo, bannermsg, **opts)