Page MenuHomePhabricator

packaging: move Inno Setup core logic into a module
ClosedPublic

Authored by indygreg on Mar 7 2019, 7:49 PM.

Details

Summary

Aspects of building the Inno Setup and WIX installers are shared.
It will make sense for them to share code.

Plus, having code in a reusable library (as opposed to a standalone
script) is just a better approach.

This commit moves the core logic to build the Inno Setup installer
into the hgpackaging package. inno/build.py is now a simple frontend
script that calls into a module to do the bulk of the work.

As part of this change, I also found a typo in build() where it was
referencing "iscc" instead of "iscc_exe." Because "iscc" was in
the global scope via the only caller, things just happened to work
before. Another benefit of always using functions and not putting
global code for main in the same file as library code.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 7 2019, 7:49 PM
This revision was automatically updated to reflect the committed changes.