| hg-reviewers |
Some platforms (ex. FreeBSD) do not have bash by default. Therefore it
should not be used in test scripts.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| (r'ls.*-\w*R', "don't use 'ls -R', use 'find'"), | (r'ls.*-\w*R', "don't use 'ls -R', use 'find'"), | ||||
| (r'printf.*[^\\]\\([1-9]|0\d)', r"don't use 'printf \NNN', use Python"), | (r'printf.*[^\\]\\([1-9]|0\d)', r"don't use 'printf \NNN', use Python"), | ||||
| (r'printf.*[^\\]\\x', "don't use printf \\x, use Python"), | (r'printf.*[^\\]\\x', "don't use printf \\x, use Python"), | ||||
| (r'\$\(.*\)', "don't use $(expr), use `expr`"), | (r'\$\(.*\)', "don't use $(expr), use `expr`"), | ||||
| (r'rm -rf \*', "don't use naked rm -rf, target a directory"), | (r'rm -rf \*', "don't use naked rm -rf, target a directory"), | ||||
| (r'\[[^\]]+==', '[ foo == bar ] is a bashism, use [ foo = bar ] instead'), | (r'\[[^\]]+==', '[ foo == bar ] is a bashism, use [ foo = bar ] instead'), | ||||
| (r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w', | (r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w', | ||||
| "use egrep for extended grep syntax"), | "use egrep for extended grep syntax"), | ||||
| (r'/bin/', "don't use explicit paths for tools"), | (r'(?<!!)/bin/', "don't use explicit paths for tools"), | ||||
| (r'#!.*/bash', "don't use bash in shebang, use sh"), | |||||
| (r'[^\n]\Z', "no trailing newline"), | (r'[^\n]\Z', "no trailing newline"), | ||||
| (r'export .*=', "don't export and assign at once"), | (r'export .*=', "don't export and assign at once"), | ||||
| (r'^source\b', "don't use 'source', use '.'"), | (r'^source\b', "don't use 'source', use '.'"), | ||||
| (r'touch -d', "don't use 'touch -d', use 'touch -t' instead"), | (r'touch -d', "don't use 'touch -d', use 'touch -t' instead"), | ||||
| (r'\bls +[^|\n-]+ +-', "options to 'ls' must come before filenames"), | (r'\bls +[^|\n-]+ +-', "options to 'ls' must come before filenames"), | ||||
| (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"), | (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"), | ||||
| (r'^stop\(\)', "don't use 'stop' as a shell function name"), | (r'^stop\(\)', "don't use 'stop' as a shell function name"), | ||||
| (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"), | (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"), | ||||
| (r'^diff.*-\w*N', "don't use 'diff -N'"), | (r'^diff.*-\w*N', "don't use 'diff -N'"), | ||||
| (r'\$PWD|\${PWD}', "don't use $PWD, use `pwd`"), | (r'\$PWD|\${PWD}', "don't use $PWD, use `pwd`"), | ||||
| (r'^([^"\'\n]|("[^"\n]*")|(\'[^\'\n]*\'))*\^', "^ must be quoted"), | (r'^([^"\'\n]|("[^"\n]*")|(\'[^\'\n]*\'))*\^', "^ must be quoted"), | ||||
| (r'kill (`|\$\()', "don't use kill, use killdaemons.py") | (r'kill (`|\$\()', "don't use kill, use killdaemons.py") | ||||
| ] | ] | ||||
| ] | ] | ||||
| testfilters = [ | testfilters = [ | ||||
| (r"( *)(#([^\n]*\S)?)", repcomment), | (r"( *)(#([^!][^\n]*\S)?)", repcomment), | ||||
| (r"<<(\S+)((.|\n)*?\n\1)", rephere), | (r"<<(\S+)((.|\n)*?\n\1)", rephere), | ||||
| ] | ] | ||||
| winglobmsg = "use (glob) to match Windows paths too" | winglobmsg = "use (glob) to match Windows paths too" | ||||
| uprefix = r"^ \$ " | uprefix = r"^ \$ " | ||||
| utestpats = [ | utestpats = [ | ||||
| [ | [ | ||||
| (r'^(\S.*|| [$>] \S.*)[ \t]\n', "trailing whitespace on non-output"), | (r'^(\S.*|| [$>] \S.*)[ \t]\n', "trailing whitespace on non-output"), | ||||
| if p.startswith(r'^'): | if p.startswith(r'^'): | ||||
| p = r"^ [$>] (%s)" % p[1:] | p = r"^ [$>] (%s)" % p[1:] | ||||
| else: | else: | ||||
| p = r"^ [$>] .*(%s)" % p | p = r"^ [$>] .*(%s)" % p | ||||
| utestpats[i].append((p, m) + tp[2:]) | utestpats[i].append((p, m) + tp[2:]) | ||||
| utestfilters = [ | utestfilters = [ | ||||
| (r"<<(\S+)((.|\n)*?\n > \1)", rephere), | (r"<<(\S+)((.|\n)*?\n > \1)", rephere), | ||||
| (r"( +)(#([^\n]*\S)?)", repcomment), | (r"( +)(#([^!][^\n]*\S)?)", repcomment), | ||||
| ] | ] | ||||
| pypats = [ | pypats = [ | ||||
| [ | [ | ||||
| (r'^\s*def\s*\w+\s*\(.*,\s*\(', | (r'^\s*def\s*\w+\s*\(.*,\s*\(', | ||||
| "tuple parameter unpacking not available in Python 3+"), | "tuple parameter unpacking not available in Python 3+"), | ||||
| (r'lambda\s*\(.*,.*\)', | (r'lambda\s*\(.*,.*\)', | ||||
| "tuple parameter unpacking not available in Python 3+"), | "tuple parameter unpacking not available in Python 3+"), | ||||