( )⚙ D610 check-code: forbid "\S" in egrep regular expression

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D610

check-code: forbid "\S" in egrep regular expression
ClosedPublic

Authored by quark on Sep 1 2017, 7:44 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG11499bad0359: check-code: forbid "\S" in egrep regular expression
Summary

BSD egrep does not like it. So let's forbid it.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Sep 1 2017, 7:44 PM
quark retitled this revision from check-code: forbid "\S" in regular expression to check-code: forbid "\S" in egrep regular expression.Sep 1 2017, 8:24 PM
Closed by commit rHG11499bad0359: check-code: forbid "\S" in egrep regular expression (authored by quark). · Explain WhySep 3 2017, 10:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 1567

contrib/check-code.py

(r'ls.*-\w*R', "don't use 'ls -R', use 'find'"), (r'ls.*-\w*R', "don't use 'ls -R', use 'find'"),
(r'printf.*[^\\]\\([1-9]|0\d)', r"don't use 'printf \NNN', use Python"), (r'printf.*[^\\]\\([1-9]|0\d)', r"don't use 'printf \NNN', use Python"),
(r'printf.*[^\\]\\x', "don't use printf \\x, use Python"), (r'printf.*[^\\]\\x', "don't use printf \\x, use Python"),
(r'\$\(.*\)', "don't use $(expr), use `expr`"), (r'\$\(.*\)', "don't use $(expr), use `expr`"),
(r'rm -rf \*', "don't use naked rm -rf, target a directory"), (r'rm -rf \*', "don't use naked rm -rf, target a directory"),
(r'\[[^\]]+==', '[ foo == bar ] is a bashism, use [ foo = bar ] instead'), (r'\[[^\]]+==', '[ foo == bar ] is a bashism, use [ foo = bar ] instead'),
(r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w', (r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w',
"use egrep for extended grep syntax"), "use egrep for extended grep syntax"),
(r'(^|\|\s*)e?grep .*\\S', "don't use \\S in regular expression"),
(r'(?<!!)/bin/', "don't use explicit paths for tools"), (r'(?<!!)/bin/', "don't use explicit paths for tools"),
(r'#!.*/bash', "don't use bash in shebang, use sh"), (r'#!.*/bash', "don't use bash in shebang, use sh"),
(r'[^\n]\Z', "no trailing newline"), (r'[^\n]\Z', "no trailing newline"),
(r'export .*=', "don't export and assign at once"), (r'export .*=', "don't export and assign at once"),
(r'^source\b', "don't use 'source', use '.'"), (r'^source\b', "don't use 'source', use '.'"),
(r'touch -d', "don't use 'touch -d', use 'touch -t' instead"), (r'touch -d', "don't use 'touch -d', use 'touch -t' instead"),
(r'\bls +[^|\n-]+ +-', "options to 'ls' must come before filenames"), (r'\bls +[^|\n-]+ +-', "options to 'ls' must come before filenames"),
(r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"), (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),

tests/test-context-metadata.t

$ hg log -r tip $ hg log -r tip
changeset: 3:ad83e9e00ec9 changeset: 3:ad83e9e00ec9
tag: tip tag: tip
parent: 1:3afb7afe6632 parent: 1:3afb7afe6632
user: test user: test
date: Thu Jan 01 00:00:00 1970 +0000 date: Thu Jan 01 00:00:00 1970 +0000
summary: Changed summary: Changed
$ hg --config extensions.metaedit=$TESTTMP/metaedit.py metaedit 'parents=0' 2>&1 | egrep '^\S*Error' $ hg --config extensions.metaedit=$TESTTMP/metaedit.py metaedit 'parents=0' 2>&1 | egrep '^RuntimeError'
RuntimeError: can't reuse the manifest: its p1 doesn't match the new ctx p1 RuntimeError: can't reuse the manifest: its p1 doesn't match the new ctx p1
$ hg --config extensions.metaedit=$TESTTMP/metaedit.py metaedit 'user=foo <foo@example.com>' $ hg --config extensions.metaedit=$TESTTMP/metaedit.py metaedit 'user=foo <foo@example.com>'
$ hg log -r tip $ hg log -r tip
changeset: 4:1f86eaeca92b changeset: 4:1f86eaeca92b
tag: tip tag: tip
parent: 1:3afb7afe6632 parent: 1:3afb7afe6632
user: foo <foo@example.com> user: foo <foo@example.com>
date: Thu Jan 01 00:00:00 1970 +0000 date: Thu Jan 01 00:00:00 1970 +0000
summary: Remove A summary: Remove A