| hg-reviewers |
MatchObject group names are strings, not bytes. Using bytes in py3 leads to an
IndexError.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| m = _differentialrevisiontagre.match(tag) | m = _differentialrevisiontagre.match(tag) | ||||
| if m: | if m: | ||||
| toconfirm[node] = (0, set(precnodes), int(m.group(1))) | toconfirm[node] = (0, set(precnodes), int(m.group(1))) | ||||
| continue | continue | ||||
| # Check commit message | # Check commit message | ||||
| m = _differentialrevisiondescre.search(ctx.description()) | m = _differentialrevisiondescre.search(ctx.description()) | ||||
| if m: | if m: | ||||
| toconfirm[node] = (1, set(precnodes), int(m.group(b'id'))) | toconfirm[node] = (1, set(precnodes), int(m.group(r'id'))) | ||||
| # Double check if tags are genuine by collecting all old nodes from | # Double check if tags are genuine by collecting all old nodes from | ||||
| # Phabricator, and expect precursors overlap with it. | # Phabricator, and expect precursors overlap with it. | ||||
| if toconfirm: | if toconfirm: | ||||
| drevs = [drev for force, precs, drev in toconfirm.values()] | drevs = [drev for force, precs, drev in toconfirm.values()] | ||||
| alldiffs = callconduit(unfi, b'differential.querydiffs', | alldiffs = callconduit(unfi, b'differential.querydiffs', | ||||
| {b'revisionIDs': drevs}) | {b'revisionIDs': drevs}) | ||||
| getnode = lambda d: bin( | getnode = lambda d: bin( | ||||
| if revid: | if revid: | ||||
| action = b'updated' | action = b'updated' | ||||
| else: | else: | ||||
| action = b'created' | action = b'created' | ||||
| # Create a local tag to note the association, if commit message | # Create a local tag to note the association, if commit message | ||||
| # does not have it already | # does not have it already | ||||
| m = _differentialrevisiondescre.search(ctx.description()) | m = _differentialrevisiondescre.search(ctx.description()) | ||||
| if not m or int(m.group(b'id')) != newrevid: | if not m or int(m.group(r'id')) != newrevid: | ||||
| tagname = b'D%d' % newrevid | tagname = b'D%d' % newrevid | ||||
| tags.tag(repo, tagname, ctx.node(), message=None, user=None, | tags.tag(repo, tagname, ctx.node(), message=None, user=None, | ||||
| date=None, local=True) | date=None, local=True) | ||||
| else: | else: | ||||
| # Nothing changed. But still set "newrevid" so the next revision | # Nothing changed. But still set "newrevid" so the next revision | ||||
| # could depend on this one. | # could depend on this one. | ||||
| newrevid = revid | newrevid = revid | ||||
| action = b'skipped' | action = b'skipped' | ||||
| def template_review(context, mapping): | def template_review(context, mapping): | ||||
| """:phabreview: Object describing the review for this changeset. | """:phabreview: Object describing the review for this changeset. | ||||
| Has attributes `url` and `id`. | Has attributes `url` and `id`. | ||||
| """ | """ | ||||
| ctx = context.resource(mapping, b'ctx') | ctx = context.resource(mapping, b'ctx') | ||||
| m = _differentialrevisiondescre.search(ctx.description()) | m = _differentialrevisiondescre.search(ctx.description()) | ||||
| if m: | if m: | ||||
| return templateutil.hybriddict({ | return templateutil.hybriddict({ | ||||
| b'url': m.group(b'url'), | b'url': m.group(r'url'), | ||||
| b'id': b"D{}".format(m.group(b'id')), | b'id': b"D{}".format(m.group(r'id')), | ||||
| }) | }) | ||||
| else: | else: | ||||
| tags = ctx.repo().nodetags(ctx.node()) | tags = ctx.repo().nodetags(ctx.node()) | ||||
| for t in tags: | for t in tags: | ||||
| if _differentialrevisiontagre.match(t): | if _differentialrevisiontagre.match(t): | ||||
| url = ctx.repo().ui.config(b'phabricator', b'url') | url = ctx.repo().ui.config(b'phabricator', b'url') | ||||
| if not url.endswith(b'/'): | if not url.endswith(b'/'): | ||||
| url += b'/' | url += b'/' | ||||
| url += t | url += t | ||||
| return templateutil.hybriddict({ | return templateutil.hybriddict({ | ||||
| b'url': url, | b'url': url, | ||||
| b'id': t, | b'id': t, | ||||
| }) | }) | ||||
| return None | return None | ||||