Page MenuHomePhabricator

memfilectx: override copysource() instead of using dummy nodeid
ClosedPublic

Authored by martinvonz on Mar 20 2019, 2:15 AM.

Details

Summary

The "_copied" property in basefilectx is used by renamed() and
copysource(). committablefilectx (which memfilectx subclasses)
overrides renamed() and writes it in terms of copysource() instead of
_copied. That means that the nodeid part of "_copied" is memfilectx is
unused. Let's instead override copysource() too so we don't need the
"_copied".

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Mar 20 2019, 2:15 AM
This revision was automatically updated to reflect the committed changes.