This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6166

fix: make the order of the work queue deterministic
ClosedPublic

Authored by hooper on Mar 21 2019, 10:56 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG8f427f7c1f71: fix: make the order of the work queue deterministic
Summary

This makes any output generated during the parallel phase of execution stable
if parallelism is disabled. This helps write tests like that in the future.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mhgext/fix.py (4 lines)

Diff 14580

hgext/fix.py

the fixes later. the fixes later.
""" """
workqueue = [] workqueue = []
numitems = collections.defaultdict(int) numitems = collections.defaultdict(int)
maxfilesize = ui.configbytes('fix', 'maxfilesize') maxfilesize = ui.configbytes('fix', 'maxfilesize')
for rev in sorted(revstofix): for rev in sorted(revstofix):
fixctx = repo[rev] fixctx = repo[rev]
match = scmutil.match(fixctx, pats, opts) match = scmutil.match(fixctx, pats, opts)
for path in pathstofix(ui, repo, pats, opts, match, basectxs[rev], for path in sorted(pathstofix(
fixctx): ui, repo, pats, opts, match, basectxs[rev], fixctx)):
fctx = fixctx[path] fctx = fixctx[path]
if fctx.islink(): if fctx.islink():
continue continue
if fctx.size() > maxfilesize: if fctx.size() > maxfilesize:
ui.warn(_('ignoring file larger than %s: %s\n') % ui.warn(_('ignoring file larger than %s: %s\n') %
(util.bytecount(maxfilesize), path)) (util.bytecount(maxfilesize), path))
continue continue
workqueue.append((rev, path)) workqueue.append((rev, path))