This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6172

remotefilelog: prefetch files in deterministic order
ClosedPublic

Authored by martinvonz on Mar 27 2019, 6:11 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG0129bf02fa04: remotefilelog: prefetch files in deterministic order
Summary

I have been troubleshooting some slowness in this area (it's unclear
if it's the client or server that's to blame, but that's beside the
point) and it's a lot easier to do troubleshoot if the files are
prefetched in the same order each time.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Mar 27 2019, 6:11 PM
Closed by commit rHG0129bf02fa04: remotefilelog: prefetch files in deterministic order (authored by martinvonz). · Explain WhyMar 29 2019, 9:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 14603

hgext/remotefilelog/fileserverclient.py

# let's log that information for debugging. # let's log that information for debugging.
if fetches >= 15 and fetches < 18: if fetches >= 15 and fetches < 18:
if fetches == 15: if fetches == 15:
fetchwarning = self.ui.config('remotefilelog', fetchwarning = self.ui.config('remotefilelog',
'fetchwarning') 'fetchwarning')
if fetchwarning: if fetchwarning:
self.ui.warn(fetchwarning + '\n') self.ui.warn(fetchwarning + '\n')
self.logstacktrace() self.logstacktrace()
missingids = [(file, hex(id)) for file, id in missingids] missingids = [(file, hex(id)) for file, id in sorted(missingids)]
fetched += len(missingids) fetched += len(missingids)
start = time.time() start = time.time()
missingids = self.request(missingids) missingids = self.request(missingids)
if missingids: if missingids:
raise error.Abort(_("unable to download %d files") % raise error.Abort(_("unable to download %d files") %
len(missingids)) len(missingids))
fetchcost += time.time() - start fetchcost += time.time() - start
self._lfsprefetch(fileids) self._lfsprefetch(fileids)