This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6195

test/test-revset2.t: Unset environment variable P (issue6109)
ClosedPublic

Authored by jerry.montfort on Apr 4 2019, 10:33 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGf3365065ef1d: tests: unset environment variable P in test-revset2.t (issue6109)
Summary

The test tests/test-revset2.t fails the test case

"Test repo.anyrevs with customized revset overrides" (line 1609)

if the environment variable P is set. The test implicitly expects that the
environment, in which it is started, does not export the variable 'P'.

To solve this issue, unset 'P' right before the test commands are run.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jerry.montfort created this revision.Apr 4 2019, 10:33 AM
jerry.montfort mentioned this in D6188: test/test-revset2.t: Unset environment variable P.Apr 4 2019, 10:37 AM
jerry.montfort retitled this revision from test/test-revset2.t: Unset environment variable P (issue1609) to test/test-revset2.t: Unset environment variable P (issue6109).
jerry.montfort added a comment.Apr 4 2019, 10:43 AM

Note: I had a typo in the issue number: I used the line number which happens to have the exact same digits as the issue number (must be destiny). To fix the typo I used the "Edit Revision" button on this web page. If that's the wrong way, I'll resend the patch if required.
For the record: The issue number is issue6109 (and the line number 1609).

pulkit accepted this revision.Apr 4 2019, 6:30 PM
Closed by commit rHGf3365065ef1d: tests: unset environment variable P in test-revset2.t (issue6109) (authored by jerry.montfort). · Explain WhyApr 4 2019, 6:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-revset2.t (1 line)

Diff 14655

tests/test-revset2.t

> ui.write(b'P=%r\n' % list(revs)) > ui.write(b'P=%r\n' % list(revs))
> EOF > EOF
$ cat >> .hg/hgrc <<EOF $ cat >> .hg/hgrc <<EOF
> custompredicate = ! > custompredicate = !
> printprevset = $TESTTMP/printprevset.py > printprevset = $TESTTMP/printprevset.py
> EOF > EOF
$ unset P
$ hg --config revsetalias.P=1 printprevset $ hg --config revsetalias.P=1 printprevset
P=[1] P=[1]
$ P=3 hg --config revsetalias.P=2 printprevset $ P=3 hg --config revsetalias.P=2 printprevset
P=[3] P=[3]
$ cd .. $ cd ..
Test obsstore related revsets Test obsstore related revsets