This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6188

test/test-revset2.t: Unset environment variable P
AbandonedPublic

Authored by jerry.montfort on Apr 3 2019, 3:04 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

tests/test-revset2.t fails the test

"Test repo.anyrevs with customized revset overrides" (line 1609)

when the environment variable P is set. The test implicitly expects that the environment, in which it is started, does not export the variable 'P'.

This patch unsets 'P' right before the test commands are run.

Fixes bug #6109

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

jerry.montfort created this revision.Apr 3 2019, 3:04 AM
pulkit added a subscriber: pulkit.Apr 3 2019, 7:47 AM

Hi, the patch looks good. However, this lacks User info, Date and other metadata. Can you try using hg phabsend (https://www.mercurial-scm.org/wiki/Phabricator) or hg email the patch? (https://www.mercurial-scm.org/wiki/ContributingChanges#Sending_patches)

Also, append the commit description with (issueNNN) as suggested by https://www.mercurial-scm.org/wiki/ContributingChanges#Patch_descriptions.

jerry.montfort added a comment.Apr 4 2019, 10:37 AM

Hi, Used hg phasbsend which created D6195. I've no clue how to merge/handle these two, so feel free to intervene.
Also added issueNNN to the commit description as suggested.

pulkit added a comment.Apr 5 2019, 7:48 AM
In D6188#90212, @jerry.montfort wrote:

Hi, Used hg phasbsend which created D6195. I've no clue how to merge/handle these two, so feel free to intervene.
Also added issueNNN to the commit description as suggested.

Thanks for the updated patch, I pushed it yesterday. This can be marked as Abandoned from the phabricator UI.

jerry.montfort abandoned this revision.Apr 5 2019, 1:55 PM

Thanks @pulkit! Abandoning revision as you suggested.

Revision Contents
Changeset List

PathPackages
Mtests/test-revset2.t (1 line)

Diff 14638

tests/test-revset2.t

> printprevset = $TESTTMP/printprevset.py > printprevset = $TESTTMP/printprevset.py
> EOF > EOF
$ unset P
$ hg --config revsetalias.P=1 printprevset $ hg --config revsetalias.P=1 printprevset
P=[1] P=[1]
$ P=3 hg --config revsetalias.P=2 printprevset $ P=3 hg --config revsetalias.P=2 printprevset