This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6283

automation: only iterate over our AMIs
ClosedPublic

Authored by indygreg on Apr 19 2019, 8:20 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG730edbd836d8: automation: only iterate over our AMIs
Summary

We can't delete AMIs that we don't own. Iterating over other
AMIs won't work and slows down execution.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Apr 19 2019, 8:20 AM
Closed by commit rHG730edbd836d8: automation: only iterate over our AMIs (authored by indygreg). · Explain WhyMay 15 2019, 11:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 15087

contrib/automation/hgautomation/aws.py

def remove_resources(c, prefix='hg-'): def remove_resources(c, prefix='hg-'):
"""Purge all of our resources in this EC2 region.""" """Purge all of our resources in this EC2 region."""
ec2resource = c.ec2resource ec2resource = c.ec2resource
iamresource = c.iamresource iamresource = c.iamresource
terminate_ec2_instances(ec2resource, prefix=prefix) terminate_ec2_instances(ec2resource, prefix=prefix)
for image in ec2resource.images.all(): for image in ec2resource.images.filter(Owners=['self']):
if image.name.startswith(prefix): if image.name.startswith(prefix):
remove_ami(ec2resource, image) remove_ami(ec2resource, image)
for group in ec2resource.security_groups.all(): for group in ec2resource.security_groups.all():
if group.group_name.startswith(prefix): if group.group_name.startswith(prefix):
print('removing security group %s' % group.group_name) print('removing security group %s' % group.group_name)
group.delete() group.delete()