| hg-reviewers |
Before this patch, the write function was so populated with upto 4 level of
indentation, it was hard to understand what's going on.
| Lint Skipped |
| Unit Tests Skipped |
| Path | Packages | |||
|---|---|---|---|---|
| M | mercurial/branchmap.py (79 lines) |
| Commit | Parents | Author | Summary | Date |
|---|---|---|---|---|
| Pulkit Goyal | Apr 19 2019, 5:44 PM |
| tr.addfinalize('write-revbranchcache', self.write) | tr.addfinalize('write-revbranchcache', self.write) | ||||
| def write(self, tr=None): | def write(self, tr=None): | ||||
| """Save branch cache if it is dirty.""" | """Save branch cache if it is dirty.""" | ||||
| repo = self._repo | repo = self._repo | ||||
| wlock = None | wlock = None | ||||
| step = '' | step = '' | ||||
| try: | try: | ||||
| # write the new names | |||||
| if self._rbcnamescount < len(self._names): | if self._rbcnamescount < len(self._names): | ||||
| wlock = repo.wlock(wait=False) | |||||
| step = ' names' | step = ' names' | ||||
| self._writenames(repo) | |||||
| # write the new revs | |||||
| start = self._rbcrevslen * _rbcrecsize | |||||
| if start != len(self._rbcrevs): | |||||
| step = '' | |||||
| if wlock is None: | |||||
| wlock = repo.wlock(wait=False) | wlock = repo.wlock(wait=False) | ||||
| self._writerevs(repo, start) | |||||
| except (IOError, OSError, error.Abort, error.LockError) as inst: | |||||
| repo.ui.debug("couldn't write revision branch cache%s: %s\n" | |||||
| % (step, stringutil.forcebytestr(inst))) | |||||
| finally: | |||||
| if wlock is not None: | |||||
| wlock.release() | |||||
| def _writenames(self, repo): | |||||
| """ write the new branch names to revbranchcache """ | |||||
| if self._rbcnamescount != 0: | if self._rbcnamescount != 0: | ||||
| f = repo.cachevfs.open(_rbcnames, 'ab') | f = repo.cachevfs.open(_rbcnames, 'ab') | ||||
| if f.tell() == self._rbcsnameslen: | if f.tell() == self._rbcsnameslen: | ||||
| f.write('\0') | f.write('\0') | ||||
| else: | else: | ||||
| f.close() | f.close() | ||||
| repo.ui.debug("%s changed - rewriting it\n" % _rbcnames) | repo.ui.debug("%s changed - rewriting it\n" % _rbcnames) | ||||
| self._rbcnamescount = 0 | self._rbcnamescount = 0 | ||||
| self._rbcrevslen = 0 | self._rbcrevslen = 0 | ||||
| if self._rbcnamescount == 0: | if self._rbcnamescount == 0: | ||||
| # before rewriting names, make sure references are removed | # before rewriting names, make sure references are removed | ||||
| repo.cachevfs.unlinkpath(_rbcrevs, ignoremissing=True) | repo.cachevfs.unlinkpath(_rbcrevs, ignoremissing=True) | ||||
| f = repo.cachevfs.open(_rbcnames, 'wb') | f = repo.cachevfs.open(_rbcnames, 'wb') | ||||
| f.write('\0'.join(encoding.fromlocal(b) | f.write('\0'.join(encoding.fromlocal(b) | ||||
| for b in self._names[self._rbcnamescount:])) | for b in self._names[self._rbcnamescount:])) | ||||
| self._rbcsnameslen = f.tell() | self._rbcsnameslen = f.tell() | ||||
| f.close() | f.close() | ||||
| self._rbcnamescount = len(self._names) | self._rbcnamescount = len(self._names) | ||||
| start = self._rbcrevslen * _rbcrecsize | def _writerevs(self, repo, start): | ||||
| if start != len(self._rbcrevs): | """ write the new revs to revbranchcache """ | ||||
| step = '' | |||||
| if wlock is None: | |||||
| wlock = repo.wlock(wait=False) | |||||
| revs = min(len(repo.changelog), | revs = min(len(repo.changelog), | ||||
| len(self._rbcrevs) // _rbcrecsize) | len(self._rbcrevs) // _rbcrecsize) | ||||
| f = repo.cachevfs.open(_rbcrevs, 'ab') | f = repo.cachevfs.open(_rbcrevs, 'ab') | ||||
| if f.tell() != start: | if f.tell() != start: | ||||
| repo.ui.debug("truncating cache/%s to %d\n" | repo.ui.debug("truncating cache/%s to %d\n" | ||||
| % (_rbcrevs, start)) | % (_rbcrevs, start)) | ||||
| f.seek(start) | f.seek(start) | ||||
| if f.tell() != start: | if f.tell() != start: | ||||
| start = 0 | start = 0 | ||||
| f.seek(start) | f.seek(start) | ||||
| f.truncate() | f.truncate() | ||||
| end = revs * _rbcrecsize | end = revs * _rbcrecsize | ||||
| f.write(self._rbcrevs[start:end]) | f.write(self._rbcrevs[start:end]) | ||||
| f.close() | f.close() | ||||
| self._rbcrevslen = revs | self._rbcrevslen = revs | ||||
| except (IOError, OSError, error.Abort, error.LockError) as inst: | |||||
| repo.ui.debug("couldn't write revision branch cache%s: %s\n" | |||||
| % (step, stringutil.forcebytestr(inst))) | |||||
| finally: | |||||
| if wlock is not None: | |||||
| wlock.release() | |||||