This is an archive of the discontinued Mercurial Phabricator instance.

	Status	Author	Revision
	Closed	pulkit	D6292 revbranchcache: use context manager in _writerevs() to write to file
	Closed	pulkit	D6291 revbranchcache: factor logic to write names and revs in separate functions

Diff 14872

	f.write('\0'.join(encoding.fromlocal(b)			f.write('\0'.join(encoding.fromlocal(b)
	for b in self._names[self._rbcnamescount:]))			for b in self._names[self._rbcnamescount:]))
	self._rbcsnameslen = f.tell()			self._rbcsnameslen = f.tell()
	f.close()			f.close()
	self._rbcnamescount = len(self._names)			self._rbcnamescount = len(self._names)

	def _writerevs(self, repo, start):			def _writerevs(self, repo, start):
	""" write the new revs to revbranchcache """			""" write the new revs to revbranchcache """
	revs = min(len(repo.changelog),			revs = min(len(repo.changelog), len(self._rbcrevs) // _rbcrecsize)
	len(self._rbcrevs) // _rbcrecsize)			with repo.cachevfs.open(_rbcrevs, 'ab') as f:
	f = repo.cachevfs.open(_rbcrevs, 'ab')
	if f.tell() != start:			if f.tell() != start:
	repo.ui.debug("truncating cache/%s to %d\n"			repo.ui.debug("truncating cache/%s to %d\n" % (_rbcrevs, start))
	% (_rbcrevs, start))
	f.seek(start)			f.seek(start)
	if f.tell() != start:			if f.tell() != start:
	start = 0			start = 0
	f.seek(start)			f.seek(start)
	f.truncate()			f.truncate()
	end = revs * _rbcrecsize			end = revs * _rbcrecsize
	f.write(self._rbcrevs[start:end])			f.write(self._rbcrevs[start:end])
	f.close()
	self._rbcrevslen = revs			self._rbcrevslen = revs

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	14872		Apr 19 2019, 5:48 PM	★	★
Diff 2	14876	rHGececa45c80d867dfe10cd9561fffaefe491f50dd	Apr 19 2019, 5:48 PM	★	★