( )⚙ D6336 localrepo: don't use defaults arguments that will never be overridden

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6336

localrepo: don't use defaults arguments that will never be overridden
ClosedPublic

Authored by martinvonz on May 3 2019, 11:55 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG39b63f9d7464: localrepo: don't use defaults arguments that will never be overridden
Summary

The commithook() callback will be called when the lock is
released. lock.release() calls the callback without arguments, so it
was quite confusing to me that this function declared extra
arguments. We can just close on the variables in the outer scope
instead.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (6 lines)

Diff 14992

mercurial/localrepo.py

cctx.markcommitted(ret) cctx.markcommitted(ret)
ms.reset() ms.reset()
except: # re-raises except: # re-raises
if edited: if edited:
self.ui.write( self.ui.write(
_('note: commit message saved in %s\n') % msgfn) _('note: commit message saved in %s\n') % msgfn)
raise raise
def commithook(node=hex(ret), parent1=hookp1, parent2=hookp2): def commithook():
# hack for command that use a temporary commit (eg: histedit) # hack for command that use a temporary commit (eg: histedit)
# temporary commit got stripped before hook release # temporary commit got stripped before hook release
if self.changelog.hasnode(ret): if self.changelog.hasnode(ret):
self.hook("commit", node=node, parent1=parent1, self.hook("commit", node=hex(ret), parent1=hookp1,
parent2=parent2) parent2=hookp2)
self._afterlock(commithook) self._afterlock(commithook)
return ret return ret
@unfilteredmethod @unfilteredmethod
def commitctx(self, ctx, error=False): def commitctx(self, ctx, error=False):
"""Add a new revision to current repository. """Add a new revision to current repository.
Revision information is passed via the context argument. Revision information is passed via the context argument.