Page MenuHomePhabricator

localrepo: don't use defaults arguments that will never be overridden
ClosedPublic

Authored by martinvonz on May 3 2019, 11:55 AM.

Details

Summary

The commithook() callback will be called when the lock is
released. lock.release() calls the callback without arguments, so it
was quite confusing to me that this function declared extra
arguments. We can just close on the variables in the outer scope
instead.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.