( )⚙ D634 encoding: check overflow while calculating size of JSON escape buffer

This is an archive of the discontinued Mercurial Phabricator instance.

encoding: check overflow while calculating size of JSON escape buffer
AbandonedPublic

Authored by singhsrb on Sep 5 2017, 8:38 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

The minimum input size to exploit is ~682MB (= INT_MAX / len('\\u0000') * 2)
on 32bit system, which isn't easy to achieve using Python str in 2GB process
address space, but probably doable.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

singhsrb created this revision.Sep 5 2017, 8:38 PM
singhsrb abandoned this revision.Sep 5 2017, 8:40 PM

Added for review by mistake.