This is an archive of the discontinued Mercurial Phabricator instance.

context: let caller pass in branch to committablectx.__init__()
ClosedPublic

Authored by martinvonz on May 11 2019, 2:11 AM.

Details

Summary

committablectx.init() currently looks up the branch from the
dirstate unless it's passed in the extras. memctx.init() has a
branch argument, but since committablectx.init() doesn't accept
it, it lets that constructor look up the branch from the dirstate
before it overwrites it, which seems awkward.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.