This is an archive of the discontinued Mercurial Phabricator instance.

Differential D638

amend: delete dead assignment to "newid"
ClosedPublic

Authored by martinvonz on Sep 6 2017, 1:57 PM.

Details

Reviewers
singhsrb
Group Reviewers
hg-reviewers
Commits
rHG4059b10d7490: amend: delete dead assignment to "newid"

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Sep 6 2017, 1:57 PM
singhsrb accepted this revision.Sep 6 2017, 3:41 PM
Closed by commit rHG4059b10d7490: amend: delete dead assignment to "newid" (authored by martinvonz). · Explain WhySep 7 2017, 10:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/cmdutil.py (1 line)

Diff 1660

mercurial/cmdutil.py

and pureextra == old.extra()): and pureextra == old.extra()):
# nothing changed. continuing here would create a new node # nothing changed. continuing here would create a new node
# anyway because of the amend_source noise. # anyway because of the amend_source noise.
# #
# This not what we expect from amend. # This not what we expect from amend.
return old.node() return old.node()
ph = repo.ui.config('phases', 'new-commit', phases.draft) ph = repo.ui.config('phases', 'new-commit', phases.draft)
newid = None
try: try:
if opts.get('secret'): if opts.get('secret'):
commitphase = 'secret' commitphase = 'secret'
else: else:
commitphase = old.phase() commitphase = old.phase()
repo.ui.setconfig('phases', 'new-commit', commitphase, 'amend') repo.ui.setconfig('phases', 'new-commit', commitphase, 'amend')
newid = repo.commitctx(new) newid = repo.commitctx(new)
finally: finally: