This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6381

exthelper: add some semi-useful trace logs
ClosedPublic

Authored by durin42 on May 15 2019, 8:57 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGc07dcf7a0247: exthelper: add some semi-useful trace logs
rHG7d4ca1ad6537: exthelper: add some semi-useful trace logs
Summary

It'd be nice to make the trace functions a little better-named in the output,
but I'm not sure how much better we can do without overhead. This at least
lets you see if a single reposetup function is eating all the time or if it's
spread over all of them. I needed this because Google's uber-extension has a
long load time and I wasn't sure where the problem was.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.May 15 2019, 8:57 PM
pulkit accepted this revision.May 16 2019, 7:14 AM
Closed by commit rHG7d4ca1ad6537: exthelper: add some semi-useful trace logs (authored by durin42). · Explain WhyMay 16 2019, 7:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/exthelper.py (12 lines)

Diff 15138

mercurial/exthelper.py

##################################################################### #####################################################################
from __future__ import absolute_import from __future__ import absolute_import
from . import ( from . import (
commands, commands,
error, error,
extensions, extensions,
pycompat,
registrar, registrar,
) )
from hgdemandimport import tracing
class exthelper(object): class exthelper(object):
"""Helper for modular extension setup """Helper for modular extension setup
A single helper should be instantiated for each module of an A single helper should be instantiated for each module of an
extension, where a command or function needs to be wrapped, or a extension, where a command or function needs to be wrapped, or a
command, extension hook, fileset, revset or template needs to be command, extension hook, fileset, revset or template needs to be
registered. Helper methods are then used as decorators for registered. Helper methods are then used as decorators for
these various purposes. If an extension spans multiple modules, these various purposes. If an extension spans multiple modules,
for command, wrapper, opts in self._commandwrappers: for command, wrapper, opts in self._commandwrappers:
entry = extensions.wrapcommand(commands.table, command, wrapper) entry = extensions.wrapcommand(commands.table, command, wrapper)
if opts: if opts:
for opt in opts: for opt in opts:
entry[1].append(opt) entry[1].append(opt)
for cont, funcname, wrapper in self._functionwrappers: for cont, funcname, wrapper in self._functionwrappers:
extensions.wrapfunction(cont, funcname, wrapper) extensions.wrapfunction(cont, funcname, wrapper)
for c in self._uicallables: for c in self._uicallables:
with tracing.log(b'finaluisetup: %s', pycompat.sysbytes(repr(c))):
c(ui) c(ui)
def finaluipopulate(self, ui): def finaluipopulate(self, ui):
"""Method to be used as the extension uipopulate """Method to be used as the extension uipopulate
This is called once per ui instance to: This is called once per ui instance to:
- Set up additional ui members - Set up additional ui members
- Update configuration by ``ui.setconfig()`` - Update configuration by ``ui.setconfig()``
continue continue
knownexts[ext] = e.cmdtable knownexts[ext] = e.cmdtable
entry = extensions.wrapcommand(knownexts[ext], command, wrapper) entry = extensions.wrapcommand(knownexts[ext], command, wrapper)
if opts: if opts:
for opt in opts: for opt in opts:
entry[1].append(opt) entry[1].append(opt)
for c in self._extcallables: for c in self._extcallables:
with tracing.log(b'finalextsetup: %s', pycompat.sysbytes(repr(c))):
c(ui) c(ui)
def finalreposetup(self, ui, repo): def finalreposetup(self, ui, repo):
"""Method to be used as the extension reposetup """Method to be used as the extension reposetup
The following operations belong here: The following operations belong here:
- All hooks but pre-* and post-* - All hooks but pre-* and post-*
- Modify configuration variables - Modify configuration variables
- Changes to repo.__class__, repo.dirstate.__class__ - Changes to repo.__class__, repo.dirstate.__class__
""" """
for c in self._repocallables: for c in self._repocallables:
with tracing.log(b'finalreposetup: %s', pycompat.sysbytes(repr(c))):
c(ui, repo) c(ui, repo)
def uisetup(self, call): def uisetup(self, call):
"""Decorated function will be executed during uisetup """Decorated function will be executed during uisetup
example:: example::
@eh.uisetup @eh.uisetup
def setupbabar(ui): def setupbabar(ui):