Page MenuHomePhabricator

checknlink: rename file object from 'fd' to 'fp'
ClosedPublic

Authored by quark on Sep 6 2017, 5:11 PM.

Details

Summary

Make it clear that fp (file object) is different from fd (low-level
file descriptor number).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Sep 6 2017, 5:11 PM
phillco accepted this revision.Sep 6 2017, 5:38 PM
phillco added a subscriber: phillco.

*rename

LGTM

mercurial/util.py
1460

Too bad there's no similar naming convention for paths.

quark retitled this revision from checknlink: renmae file object from 'fd' to 'fp' to checknlink: rename file object from 'fd' to 'fp'.Sep 6 2017, 8:31 PM
This revision was automatically updated to reflect the committed changes.