Page MenuHomePhabricator

commitextras: try to remove localrepo hacking to add extras to commit
Needs RevisionPublic

Authored by pulkit on May 30 2019, 2:20 PM.

Details

Reviewers
baymax
Group Reviewers
hg-reviewers

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.May 30 2019, 2:20 PM
pulkit added a comment.EditedMay 30 2019, 2:21 PM

I am not sure this is good way to do this. But I will definitely like to remove the hacking around localrepo to add extras to a commit.

Can you elaborate a bit about what the current hack does and why it's bad?

baymax requested changes to this revision.Jan 24 2020, 12:32 PM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.

:baymax:need-review-idle:

This revision now requires changes to proceed.Jan 24 2020, 12:32 PM