Page MenuHomePhabricator

phabricator: use parents.set to always set dependencies
ClosedPublic

Authored by Kwan on Wed, Jun 12, 12:44 PM.

Details

Summary

Now that Mercurial's Phabricator instance has been updated to a version that
supports the parents.set transaction on revision.edit we can use that to set
dependency relationships in patch stacks instead of abusing the summary.
This has the advantage that we can use it on every phabsend so commit
reordering is picked up without spamming changes like abusing the summary would,
and using parents.set will clear previous parents unlike parents.add.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Wed, Jun 12, 12:44 PM

Is it worth adding a test using histedit, or is the use in existing tests enough?

durin42 accepted this revision.Wed, Jun 12, 12:48 PM

I think the existing changes are enough. I'm overjoyed at this feature: this has been the single biggest pain point I've experienced with phabricator both as an author and as a reviewer. Thank you!

This revision is now accepted and ready to land.Wed, Jun 12, 12:48 PM
This revision was automatically updated to reflect the committed changes.