This is an archive of the discontinued Mercurial Phabricator instance.

blackbox: set lastui even if ui.log is not called (issue5518)
ClosedPublic

Authored by quark on Sep 7 2017, 1:33 AM.

Details

Summary

lastui decides where (where is the .hg) to use if the current ui
object does not have a _bbrepo associated. Previously it only gets set in
ui.log, which means unless a ui with repo associated calls log with
tracked event, blackbox does not know where to write its log. This patch
makes reposetup set lastui so it so we could log some more events (see
test changes).

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Sep 7 2017, 1:33 AM
durham accepted this revision.Sep 7 2017, 8:26 PM
durham added a subscriber: durham.

It might be worth mentioning what lastui is use for in the commit message. I had to look at the code a little to remember what lastui did and why this was safe.

quark edited the summary of this revision. (Show Details)Sep 18 2017, 7:03 PM
quark updated this revision to Diff 1880.
quark updated this revision to Diff 1898.Sep 19 2017, 1:50 PM
This revision was automatically updated to reflect the committed changes.