Page MenuHomePhabricator

blackbox: disable extremely verbose logging (issue6110)
ClosedPublic

Authored by valentin.gatienbaron on Jul 7 2019, 12:13 PM.

Details

Summary

This is maybe not the best way to go about fixing this, but anything
is better than the status quo.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 added inline comments.
hgext/blackbox.py
102

Let's make this configurable, and this is the default. Maybe blackbox.ignore, with a default of the things you've specified?

valentin.gatienbaron marked an inline comment as done.Jul 10 2019, 6:21 PM
valentin.gatienbaron added inline comments.
hgext/blackbox.py
102

I made the ignore list configurable, although it seems to be of limited utility: you can replace the default, but extending seems like the more useful thing to do. Extending the list requires repeating the default, and the default may not be particularly stable across versions.

I changed the priority of tracked and ignored, so tracked takes predecence. This means that tracked = *, cmdserver would log cmdserver events, as that seems a bit better to me and maybe that's why you wanted the configurability.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.