This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6611

blackbox: disable extremely verbose logging (issue6110)
ClosedPublic

Authored by valentin.gatienbaron on Jul 7 2019, 12:13 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG56132ebd14c6: blackbox: disable extremely verbose logging (issue6110)
rHG341222d54bea: blackbox: disable extremely verbose logging (issue6110)
Summary

This is maybe not the best way to go about fixing this, but anything
is better than the status quo.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 added a subscriber: durin42.Jul 10 2019, 3:38 PM
durin42 added inline comments.
hgext/blackbox.py
102

Let's make this configurable, and this is the default. Maybe blackbox.ignore, with a default of the things you've specified?

valentin.gatienbaron marked an inline comment as done.Jul 10 2019, 6:21 PM
valentin.gatienbaron added inline comments.
hgext/blackbox.py
102

I made the ignore list configurable, although it seems to be of limited utility: you can replace the default, but extending seems like the more useful thing to do. Extending the list requires repeating the default, and the default may not be particularly stable across versions.

I changed the priority of tracked and ignored, so tracked takes predecence. This means that tracked = *, cmdserver would log cmdserver events, as that seems a bit better to me and maybe that's why you wanted the configurability.

valentin.gatienbaron added a commit: rHG341222d54bea: blackbox: disable extremely verbose logging (issue6110).Jul 17 2019, 7:05 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG341222d54bea: blackbox: disable extremely verbose logging (issue6110) (authored by valentin.gatienbaron). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/blackbox.py (12 lines)
Mtests/test-blackbox.t (3 lines)

Diff 15944

hgext/blackbox.py

# blackbox.py - log repository events to a file for post-mortem debugging # blackbox.py - log repository events to a file for post-mortem debugging
# #
# Copyright 2010 Nicolas Dumazet # Copyright 2010 Nicolas Dumazet
# Copyright 2013 Facebook, Inc. # Copyright 2013 Facebook, Inc.
# #
# This software may be used and distributed according to the terms of the # This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version. # GNU General Public License version 2 or any later version.
"""log repository events to a blackbox for debugging """log repository events to a blackbox for debugging
Logs event information to .hg/blackbox.log to help debug and diagnose problems. Logs event information to .hg/blackbox.log to help debug and diagnose problems.
The events that get logged can be configured via the blackbox.track config key. The events that get logged can be configured via the blackbox.track and
blackbox.ignore config keys.
Examples:: Examples::
[blackbox] [blackbox]
track = * track = *
ignore = pythonhook
# dirty is *EXPENSIVE* (slow); # dirty is *EXPENSIVE* (slow);
# each log entry indicates `+` if the repository is dirty, like :hg:`id`. # each log entry indicates `+` if the repository is dirty, like :hg:`id`.
dirty = True dirty = True
# record the source of log messages # record the source of log messages
logsource = True logsource = True
[blackbox] [blackbox]
track = command, commandfinish, commandexception, exthook, pythonhook track = command, commandfinish, commandexception, exthook, pythonhook
default=False, default=False,
) )
configitem('blackbox', 'maxfiles', configitem('blackbox', 'maxfiles',
default=7, default=7,
) )
configitem('blackbox', 'track', configitem('blackbox', 'track',
default=lambda: ['*'], default=lambda: ['*'],
) )
configitem('blackbox', 'ignore',
default=lambda: ['chgserver', 'cmdserver', 'extension'],
)
configitem('blackbox', 'date-format', configitem('blackbox', 'date-format',
default='%Y/%m/%d %H:%M:%S', default='%Y/%m/%d %H:%M:%S',
) )
_lastlogger = loggingutil.proxylogger() _lastlogger = loggingutil.proxylogger()
class blackboxlogger(object): class blackboxlogger(object):
def __init__(self, ui, repo): def __init__(self, ui, repo):
self._repo = repo self._repo = repo
self._trackedevents = set(ui.configlist('blackbox', 'track')) self._trackedevents = set(ui.configlist('blackbox', 'track'))
self._ignoredevents = set(ui.configlist('blackbox', 'ignore'))
durin42Unsubmitted
Not Done

Let's make this configurable, and this is the default. Maybe blackbox.ignore, with a default of the things you've specified?

durin42: Let's make this configurable, and this is the default. Maybe blackbox.ignore, with a default of…
valentin.gatienbaronAuthorUnsubmitted
Done

I made the ignore list configurable, although it seems to be of limited utility: you can replace the default, but extending seems like the more useful thing to do. Extending the list requires repeating the default, and the default may not be particularly stable across versions.

I changed the priority of tracked and ignored, so tracked takes predecence. This means that tracked = *, cmdserver would log cmdserver events, as that seems a bit better to me and maybe that's why you wanted the configurability.

valentin.gatienbaron: I made the ignore list configurable, although it seems to be of limited utility: you can…
self._maxfiles = ui.configint('blackbox', 'maxfiles') self._maxfiles = ui.configint('blackbox', 'maxfiles')
self._maxsize = ui.configbytes('blackbox', 'maxsize') self._maxsize = ui.configbytes('blackbox', 'maxsize')
self._inlog = False self._inlog = False
def tracked(self, event): def tracked(self, event):
return b'*' in self._trackedevents or event in self._trackedevents return ((b'*' in self._trackedevents
and event not in self._ignoredevents)
or event in self._trackedevents)
def log(self, ui, event, msg, opts): def log(self, ui, event, msg, opts):
# self._log() -> ctx.dirty() may create new subrepo instance, which # self._log() -> ctx.dirty() may create new subrepo instance, which
# ui is derived from baseui. So the recursion guard in ui.log() # ui is derived from baseui. So the recursion guard in ui.log()
# doesn't work as it's local to the ui instance. # doesn't work as it's local to the ui instance.
if self._inlog: if self._inlog:
return return
self._inlog = True self._inlog = True

tests/test-blackbox.t

> [extensions] > [extensions]
> blackbox= > blackbox=
> mock=$TESTDIR/mockblackbox.py > mock=$TESTDIR/mockblackbox.py
> mq= > mq=
> myextension=$TESTTMP/myextension.py > myextension=$TESTTMP/myextension.py
> [alias] > [alias]
> confuse = log --limit 3 > confuse = log --limit 3
> so-confusing = confuse --style compact > so-confusing = confuse --style compact
> [blackbox]
> track = backupbundle, branchcache, command, commandalias, commandexception,
> commandfinish, debug, exthook, incoming, pythonhook, tagscache
> EOF > EOF
$ hg init blackboxtest $ hg init blackboxtest
$ cd blackboxtest $ cd blackboxtest
command, exit codes, and duration command, exit codes, and duration
$ echo a > a $ echo a > a