Page MenuHomePhabricator

unshelve: abort on using --keep and --interactive together

Authored by navaneeth.suresh on Jul 27 2019, 12:11 AM.



I am working on making interactive mode support --keep flag. Until
we support the usage of --interactive and --keep together, let
us abort on it.

Diff Detail

rHG Mercurial
Lint Skipped
Unit Tests Skipped

Event Timeline

pulkit added a subscriber: pulkit.Aug 6 2019, 7:12 AM
pulkit added inline comments.

Can you show what the new shelve contains? Also add a test when there is partial unshelving going.

pulkit added a comment.Aug 7 2019, 6:18 PM

You are already working on improving things with --keep and --interactive, so let's have this patch as a part of that patch.

navaneeth.suresh retitled this revision from tests: add test for unshelve --interactive --keep to unshelve: abort on using --keep and --interactive together.Aug 9 2019, 2:42 PM
navaneeth.suresh edited the summary of this revision. (Show Details)
navaneeth.suresh updated this revision to Diff 16166.
pulkit added inline comments.Aug 9 2019, 2:55 PM
971 ↗(On Diff #16166)

--keep on --interactive ...

navaneeth.suresh marked an inline comment as done.Aug 9 2019, 3:16 PM
pulkit accepted this revision.Aug 15 2019, 10:48 AM
pulkit added inline comments.

Sorry for missing this earlier, let's move this check above. Maybe before line 944 on this side.

This revision is now accepted and ready to land.Aug 15 2019, 10:48 AM