This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	valentin.gatienbaron	D6831 exchange: convert bookmark nodes from hex to bin ASAP
Closed	valentin.gatienbaron	D6830 exchange: avoid unnecessary conversion of bookmark nodes to hex (API)
Closed	valentin.gatienbaron	D6829 doc: fix up confusing doc comment

Diff 16517

	repo = pushop.repo.unfiltered()			repo = pushop.repo.unfiltered()
	remote = pushop.remote			remote = pushop.remote
	ui.debug("checking for updated bookmarks\n")			ui.debug("checking for updated bookmarks\n")
	ancestors = ()			ancestors = ()
	if pushop.revs:			if pushop.revs:
	revnums = pycompat.maplist(repo.changelog.rev, pushop.revs)			revnums = pycompat.maplist(repo.changelog.rev, pushop.revs)
	ancestors = repo.changelog.ancestors(revnums, inclusive=True)			ancestors = repo.changelog.ancestors(revnums, inclusive=True)

	remotebookmark = listkeys(remote, 'bookmarks')			remotebookmark = bookmod.unhexlifybookmarks(listkeys(remote, 'bookmarks'))

	explicit = {repo._bookmarks.expandname(bookmark)			explicit = {repo._bookmarks.expandname(bookmark)
	for bookmark in pushop.bookmarks}			for bookmark in pushop.bookmarks}

	remotebookmark = bookmod.unhexlifybookmarks(remotebookmark)
	comp = bookmod.comparebookmarks(repo, repo._bookmarks, remotebookmark)			comp = bookmod.comparebookmarks(repo, repo._bookmarks, remotebookmark)
	return _processcompared(pushop, ancestors, explicit, remotebookmark, comp)			return _processcompared(pushop, ancestors, explicit, remotebookmark, comp)

	def _processcompared(pushop, pushed, explicit, remotebms, comp):			def _processcompared(pushop, pushed, explicit, remotebms, comp):
	"""take decision on bookmarks to push to the remote repo			"""take decision on bookmarks to push to the remote repo

	Exists to help extensions alter this behavior.			Exists to help extensions alter this behavior.
	"""			"""