This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6852

tests: stabilize test-fix.t on Windows
ClosedPublic

Authored by mharbison72 on Sep 14 2019, 1:59 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGa2dffe68b4ea: tests: stabilize test-fix.t on Windows
Summary

pwd prints /tmp/... style paths, not C:\... needed for $TESTTMP to be
substituted.

In the final test, for whatever reason, Windows was missing EOL in the files and
printing:

[wdir] changedlines: printf: warning: ignoring excess arguments, starting
   with 'printf'

even though it was trying to run:

printf "Line ranges:\n"; printf "2 through 2\n";

I tried wrapping both :command and :linerange in sh -c "...", and while that
fixed the missing EOL, it missed the "2 through 2" output.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Sep 14 2019, 1:59 PM
pulkit accepted this revision.Sep 16 2019, 1:11 PM
This revision is now accepted and ready to land.Sep 16 2019, 1:11 PM
mharbison72 added a commit: rHGa2dffe68b4ea: tests: stabilize test-fix.t on Windows.Sep 16 2019, 1:56 PM
Closed by commit rHGa2dffe68b4ea: tests: stabilize test-fix.t on Windows (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-fix.t (12 lines)

Diff 16561

tests/test-fix.t

the tool knowledge of the repo's location in case it can do something the tool knowledge of the repo's location in case it can do something
reasonable with that. reasonable with that.
$ hg init subprocesscwd $ hg init subprocesscwd
$ cd subprocesscwd $ cd subprocesscwd
$ cat >> .hg/hgrc <<EOF $ cat >> .hg/hgrc <<EOF
> [fix] > [fix]
> printcwd:command = pwd > printcwd:command = "$PYTHON" -c "import os; print(os.getcwd())"
> printcwd:pattern = path:foo/bar > printcwd:pattern = path:foo/bar
> EOF > EOF
$ mkdir foo $ mkdir foo
$ printf "bar\n" > foo/bar $ printf "bar\n" > foo/bar
$ hg commit -Aqm blah $ hg commit -Aqm blah
$ hg fix -w -r . foo/bar $ hg fix -w -r . foo/bar
$ printf "a\nb\nc\n" > foo $ printf "a\nb\nc\n" > foo
$ printf "a\nb\nc\n" > bar $ printf "a\nb\nc\n" > bar
$ printf "a\nb\nc\n" > baz $ printf "a\nb\nc\n" > baz
$ hg commit -Aqm "base" $ hg commit -Aqm "base"
$ printf "a\nc\n" > foo $ printf "a\nc\n" > foo
$ printf "a\nx\nc\n" > baz $ printf "a\nx\nc\n" > baz
$ cat >> print.py <<EOF
> import sys
> for a in sys.argv[1:]:
> print(a)
> EOF
$ hg fix --working-dir foo bar baz \ $ hg fix --working-dir foo bar baz \
> --config 'fix.changedlines:command=printf "Line ranges:\n"; ' \ > --config "fix.changedlines:command=\"$PYTHON\" print.py \"Line ranges:\"" \
> --config 'fix.changedlines:linerange=printf "{first} through {last}\n"; ' \ > --config 'fix.changedlines:linerange="{first} through {last}"' \
> --config 'fix.changedlines:pattern=rootglob:**' \ > --config 'fix.changedlines:pattern=rootglob:**' \
> --config 'fix.changedlines:skipclean=false' > --config 'fix.changedlines:skipclean=false'
$ cat foo $ cat foo
Line ranges: Line ranges:
$ cat bar $ cat bar
Line ranges: Line ranges:
$ cat baz $ cat baz
Line ranges: Line ranges:
2 through 2 2 through 2
$ cd .. $ cd ..