This is an archive of the discontinued Mercurial Phabricator instance.

Differential D69

tests: put temporary files in $TESTTMP
AbandonedPublic

Authored by simpkins on Jul 12 2017, 7:42 PM.

Details

Reviewers
quark
Group Reviewers
hg-reviewers
Summary

Update test-check-pyflakes.t to write test.py in the $TESTTMP directory.
Previously when using "run_tests.py -l" it would write test.py into your local
repository, leaving it behind as an untracked file after the test finished.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

simpkins created this revision.Jul 12 2017, 7:42 PM
quark accepted this revision.Jul 12 2017, 8:06 PM
quark added a subscriber: quark.

Ha, D67 was supposed to fix the same thing.

quark added inline comments.Jul 12 2017, 8:07 PM
tests/test-check-pyflakes.t
13

In theory this needs a "(glob)" at the end of the line. (test-check-code might complain about this)

simpkins abandoned this revision.Jul 13 2017, 10:40 PM

D67 has landed in hgcommitted, so this isn't really necessary any more.

Revision Contents
Changeset List

PathPackages
Mtests/test-check-pyflakes.t (6 lines)

Diff 97

tests/test-check-pyflakes.t

#require test-repo pyflakes hg10 #require test-repo pyflakes hg10
$ . "$TESTDIR/helpers-testrepo.sh" $ . "$TESTDIR/helpers-testrepo.sh"
$ cd "`dirname "$TESTDIR"`" $ cd "`dirname "$TESTDIR"`"
run pyflakes on all tracked files ending in .py or without a file ending run pyflakes on all tracked files ending in .py or without a file ending
(skipping binary file random-seed) (skipping binary file random-seed)
$ cat > test.py <<EOF $ cat > "$TESTTMP/test.py" <<EOF
> print(undefinedname) > print(undefinedname)
> EOF > EOF
$ pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py" $ pyflakes "$TESTTMP/test.py" 2>/dev/null | "$TESTDIR/filterpyflakes.py"
test.py:1: undefined name 'undefinedname' $TESTTMP/test.py:1: undefined name 'undefinedname'
quarkUnsubmitted
Not Done

In theory this needs a "(glob)" at the end of the line. (test-check-code might complain about this)

quark: In theory this needs a "(glob)" at the end of the line. (test-check-code might complain about…
$ testrepohg locate 'set:**.py or grep("^#!.*python")' \ $ testrepohg locate 'set:**.py or grep("^#!.*python")' \
> -X hgext/fsmonitor/pywatchman \ > -X hgext/fsmonitor/pywatchman \
> -X mercurial/pycompat.py -X contrib/python-zstandard \ > -X mercurial/pycompat.py -X contrib/python-zstandard \
> 2>/dev/null \ > 2>/dev/null \
> | xargs pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py" > | xargs pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py"