This is an archive of the discontinued Mercurial Phabricator instance.

Differential D702

gitlookup: reorganising the imports
ClosedPublic

Authored by singhsrb on Sep 13 2017, 5:48 PM.
Tags
None
Subscribers
durham

Details

Reviewers
durham
Group Reviewers
Restricted Project
Commits
rFBHGXb2632ca4f000: gitlookup: reorganising the imports
Summary

Reorganising the imports in the file gitlookup.py to comply with the
recommended way.

Test Plan

Ran all the tests.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

singhsrb created this revision.Sep 13 2017, 5:48 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2017, 5:48 PM
durham accepted this revision.Sep 13 2017, 7:57 PM
durham added a subscriber: durham.
durham added inline comments.
hgext3rd/gitlookup.py
41

It looks like urllib is dropped. Should this have been dropped as part of the previous patch?

This revision is now accepted and ready to land.Sep 13 2017, 7:57 PM
singhsrb added inline comments.Sep 13 2017, 8:00 PM
hgext3rd/gitlookup.py
41

Yes, i messed up during the split!

singhsrb updated this revision to Diff 1797.Sep 13 2017, 8:06 PM
Closed by commit rFBHGXb2632ca4f000: gitlookup: reorganising the imports (authored by singhsrb). · Explain WhySep 15 2017, 12:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext3rd/gitlookup.py (26 lines)

Diff 1855

hgext3rd/gitlookup.py

# The config option onlymapdelta controls how the server handles the hg-git # The config option onlymapdelta controls how the server handles the hg-git
# map. A True value corresponds to serving only missing map data while False # map. A True value corresponds to serving only missing map data while False
# corresponds to serving the complete map. # corresponds to serving the complete map.
onlymapdelta = False onlymapdelta = False
''' '''
from mercurial import bundle2, exchange, encoding, extensions, hg import errno
from mercurial import localrepo, util, wireproto, error, registrar import json
from mercurial.node import bin, hex, nullid
from mercurial import (
bundle2,
encoding,
error,
exchange,
extensions,
hg,
localrepo,
registrar,
util,
wireproto,
)
from mercurial.node import (
bin,
hex,
nullid,
)
from mercurial.i18n import _ from mercurial.i18n import _
import errno, json
durhamUnsubmitted
Not Done

It looks like urllib is dropped. Should this have been dropped as part of the previous patch?

durham: It looks like urllib is dropped. Should this have been dropped as part of the previous patch?
singhsrbAuthorUnsubmitted
Not Done

Yes, i messed up during the split!

singhsrb: Yes, i messed up during the split!
cmdtable = {} cmdtable = {}
command = registrar.command(cmdtable) command = registrar.command(cmdtable)
def wrapwireprotocommand(command, wrapper): def wrapwireprotocommand(command, wrapper):
'''Wrap the wire proto command named `command' in table '''Wrap the wire proto command named `command' in table
Just like extensions.wrapcommand, except for wire protocol commands. Just like extensions.wrapcommand, except for wire protocol commands.