( )⚙ D7117 rust-dirstatemap: remove additional lookups in dirstatemap

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7117

rust-dirstatemap: remove additional lookups in dirstatemap
ClosedPublic

Authored by Alphare on Oct 16 2019, 9:48 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG5d4046594d6f: rust-dirstatemap: remove additional lookups in dirstatemap
Summary

We're copying this shortcut from the Python implementation, pretty standard
for this codebase.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Oct 16 2019, 9:48 AM
Alphare added a commit: rHG5d4046594d6f: rust-dirstatemap: remove additional lookups in dirstatemap.Oct 18 2019, 7:08 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG5d4046594d6f: rust-dirstatemap: remove additional lookups in dirstatemap (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstate.py (4 lines)

Diff 17337

mercurial/dirstate.py

if not st: if not st:
return return
parse_dirstate = util.nogc(self._rustmap.read) parse_dirstate = util.nogc(self._rustmap.read)
parents = parse_dirstate(st) parents = parse_dirstate(st)
if parents and not self._dirtyparents: if parents and not self._dirtyparents:
self.setparents(*parents) self.setparents(*parents)
self.__contains__ = self._rustmap.__contains__
self.__getitem__ = self._rustmap.__getitem__
self.get = self._rustmap.get
def write(self, st, now): def write(self, st, now):
parents = self.parents() parents = self.parents()
st.write(self._rustmap.write(parents[0], parents[1], now)) st.write(self._rustmap.write(parents[0], parents[1], now))
st.close() st.close()
self._dirtyparents = False self._dirtyparents = False
@propertycache @propertycache
def filefoldmap(self): def filefoldmap(self):