This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7130

automation: avoid '~' in the temp directory on Windows
ClosedPublic

Authored by mharbison72 on Oct 17 2019, 5:58 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGa77338d2bdab: automation: avoid '~' in the temp directory on Windows
Summary

If a long-ish username is used, the environment variable ends up with a '~' to
be 8.3 path compatible. That in turn causes a handful of tests (mostly ssh
related) to add quotes around $TESTMP.

I have no AWS experience, so I have no idea if this is the proper way to do it.
But I've hit this problem locally, and redirecting the directory is a
workaround. I don't recall if the directory is created on demand by the test
harness, but presumably if this is configured before the machine boots, Windows
will do it for us.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Oct 17 2019, 5:58 PM
mharbison72 added a commit: rHGa77338d2bdab: automation: avoid '~' in the temp directory on Windows.Nov 5 2019, 12:29 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGa77338d2bdab: automation: avoid '~' in the temp directory on Windows (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 17550

contrib/automation/hgautomation/aws.py

winrm set winrm/config/service/auth '@{Basic="true"}' winrm set winrm/config/service/auth '@{Basic="true"}'
winrm set winrm/config/client/auth '@{Basic="true"}' winrm set winrm/config/client/auth '@{Basic="true"}'
# Configure UAC to allow privilege elevation in remote shells # Configure UAC to allow privilege elevation in remote shells
$Key = 'HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\Policies\System' $Key = 'HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\Policies\System'
$Setting = 'LocalAccountTokenFilterPolicy' $Setting = 'LocalAccountTokenFilterPolicy'
Set-ItemProperty -Path $Key -Name $Setting -Value 1 -Force Set-ItemProperty -Path $Key -Name $Setting -Value 1 -Force
# Avoid long usernames in the temp directory path because the '~' causes extra quoting in ssh output
[System.Environment]::SetEnvironmentVariable('TMP', 'C:\Temp', [System.EnvironmentVariableTarget]::User)
[System.Environment]::SetEnvironmentVariable('TEMP', 'C:\Temp', [System.EnvironmentVariableTarget]::User)
# Configure and restart the WinRM Service; Enable the required firewall exception # Configure and restart the WinRM Service; Enable the required firewall exception
Stop-Service -Name WinRM Stop-Service -Name WinRM
Set-Service -Name WinRM -StartupType Automatic Set-Service -Name WinRM -StartupType Automatic
netsh advfirewall firewall set rule name="Windows Remote Management (HTTP-In)" new action=allow localip=any remoteip=any netsh advfirewall firewall set rule name="Windows Remote Management (HTTP-In)" new action=allow localip=any remoteip=any
Start-Service -Name WinRM Start-Service -Name WinRM
# Disable firewall on private network interfaces so prompts don't appear. # Disable firewall on private network interfaces so prompts don't appear.
Set-NetFirewallProfile -Name private -Enabled false Set-NetFirewallProfile -Name private -Enabled false