This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7134

phabricator: use context manager form of progress in uploadchunks
ClosedPublic

Authored by Kwan on Oct 18 2019, 2:21 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGa78a65c33b5a: phabricator: use context manager form of progress in uploadchunks
Summary

Follow-up to 453079605242 / D7046.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Oct 18 2019, 2:21 AM
Kwan updated this revision to Diff 17494.Nov 1 2019, 8:57 PM

Rebase onto stable

Kwan added a commit: rHGa78a65c33b5a: phabricator: use context manager form of progress in uploadchunks.Nov 8 2019, 1:25 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGa78a65c33b5a: phabricator: use context manager form of progress in uploadchunks (authored by Kwan). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (37 lines)

Diff 17795

hgext/phabricator.py

def uploadchunks(fctx, fphid): def uploadchunks(fctx, fphid):
"""upload large binary files as separate chunks. """upload large binary files as separate chunks.
Phab requests chunking over 8MiB, and splits into 4MiB chunks Phab requests chunking over 8MiB, and splits into 4MiB chunks
""" """
ui = fctx.repo().ui ui = fctx.repo().ui
chunks = callconduit(ui, b'file.querychunks', {b'filePHID': fphid}) chunks = callconduit(ui, b'file.querychunks', {b'filePHID': fphid})
progress = ui.makeprogress( with ui.makeprogress(
_(b'uploading file chunks'), unit=_(b'chunks'), total=len(chunks) _(b'uploading file chunks'), unit=_(b'chunks'), total=len(chunks)
) ) as progress:
for chunk in chunks: for chunk in chunks:
progress.increment() progress.increment()
if chunk[b'complete']: if chunk[b'complete']:
continue continue
bstart = int(chunk[b'byteStart']) bstart = int(chunk[b'byteStart'])
bend = int(chunk[b'byteEnd']) bend = int(chunk[b'byteEnd'])
callconduit( callconduit(
ui, ui,
b'file.uploadchunk', b'file.uploadchunk',
{ {
b'filePHID': fphid, b'filePHID': fphid,
b'byteStart': bstart, b'byteStart': bstart,
b'data': base64.b64encode(fctx.data()[bstart:bend]), b'data': base64.b64encode(fctx.data()[bstart:bend]),
b'dataEncoding': b'base64', b'dataEncoding': b'base64',
}, },
) )
progress.complete()
def uploadfile(fctx): def uploadfile(fctx):
"""upload binary files to Phabricator""" """upload binary files to Phabricator"""
repo = fctx.repo() repo = fctx.repo()
ui = repo.ui ui = repo.ui
fname = fctx.path() fname = fctx.path()
size = fctx.size() size = fctx.size()