Page MenuHomePhabricator

phabricator: add the uploadchunks function

Authored by Kwan on Oct 10 2019, 5:52 PM.

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Oct 10 2019, 5:52 PM
Kwan updated this revision to Diff 17077.Oct 11 2019, 1:54 PM

Fix some test-check-code issues, and one test-check-pyflakes unused local.

indygreg accepted this revision.Oct 11 2019, 9:48 PM
indygreg added a subscriber: indygreg.
indygreg added inline comments.

Could you please follow up and use the context manager form of progress. Otherwise exceptions can result in an orphaned progress bar.

This revision is now accepted and ready to land.Oct 11 2019, 9:48 PM
This revision was automatically updated to reflect the committed changes.