This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7046

phabricator: add the uploadchunks function
ClosedPublic

Authored by Kwan on Oct 10 2019, 5:52 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG453079605242: phabricator: add the uploadchunks function

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Oct 10 2019, 5:52 PM
Kwan updated this revision to Diff 17077.Oct 11 2019, 1:54 PM

Fix some test-check-code issues, and one test-check-pyflakes unused local.

indygreg accepted this revision.Oct 11 2019, 9:48 PM
indygreg added a subscriber: indygreg.
indygreg added inline comments.
hgext/phabricator.py
608

Could you please follow up and use the context manager form of progress. Otherwise exceptions can result in an orphaned progress bar.

This revision is now accepted and ready to land.Oct 11 2019, 9:48 PM
Kwan added a commit: rHG453079605242: phabricator: add the uploadchunks function.Oct 11 2019, 9:56 PM
Closed by commit rHG453079605242: phabricator: add the uploadchunks function (authored by Kwan). · Explain Why
This revision was automatically updated to reflect the committed changes.
RoryCrona added a subscriber: RoryCrona.Mar 2 2022, 8:46 AM

As said in this article using the airdorid 4.0 is very easy and smooth. The https://www.resumehelpservices.com/resumespice-com-review/ blog developers has done very good job in this latest version by bringing new features into it and making it user friendly app which can run on any user interface and operating system which is very good thing for the users.

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (29 lines)

Diff 17094

hgext/phabricator.py

example.prefix = phab.example.com example.prefix = phab.example.com
# API token. Get it from https://$HOST/conduit/login/ # API token. Get it from https://$HOST/conduit/login/
example.phabtoken = cli-xxxxxxxxxxxxxxxxxxxxxxxxxxxx example.phabtoken = cli-xxxxxxxxxxxxxxxxxxxxxxxxxxxx
""" """
from __future__ import absolute_import from __future__ import absolute_import
import base64
import contextlib import contextlib
import itertools import itertools
import json import json
import operator import operator
import re import re
from mercurial.node import bin, nullid from mercurial.node import bin, nullid
from mercurial.i18n import _ from mercurial.i18n import _
newLength, newLength,
corpus, corpus,
addLines, addLines,
delLines, delLines,
) )
) )
def uploadchunks(fctx, fphid):
"""upload large binary files as separate chunks.
Phab requests chunking over 8MiB, and splits into 4MiB chunks
"""
ui = fctx.repo().ui
chunks = callconduit(ui, b'file.querychunks', {b'filePHID': fphid})
progress = ui.makeprogress(
_(b'uploading file chunks'), unit=_(b'chunks'), total=len(chunks)
)
for chunk in chunks:
progress.increment()
if chunk[b'complete']:
continue
bstart = int(chunk[b'byteStart'])
bend = int(chunk[b'byteEnd'])
callconduit(
ui,
b'file.uploadchunk',
{
b'filePHID': fphid,
b'byteStart': bstart,
b'data': base64.b64encode(fctx.data()[bstart:bend]),
b'dataEncoding': b'base64',
},
)
progress.complete()
indygregUnsubmitted
Not Done

Could you please follow up and use the context manager form of progress. Otherwise exceptions can result in an orphaned progress bar.

indygreg: Could you please follow up and use the context manager form of progress. Otherwise exceptions…
def creatediff(ctx): def creatediff(ctx):
"""create a Differential Diff""" """create a Differential Diff"""
repo = ctx.repo() repo = ctx.repo()
repophid = getrepophid(repo) repophid = getrepophid(repo)
# Create a "Differential Diff" via "differential.createrawdiff" API # Create a "Differential Diff" via "differential.createrawdiff" API
params = {b'diff': getdiff(ctx, mdiff.diffopts(git=True, context=32767))} params = {b'diff': getdiff(ctx, mdiff.diffopts(git=True, context=32767))}
if repophid: if repophid:
params[b'repositoryPHID'] = repophid params[b'repositoryPHID'] = repophid