This is an archive of the discontinued Mercurial Phabricator instance.

phabricator: convert phabhunk and phabchange keys to bytes when finalising

Authored by Kwan on Oct 12 2019, 9:45 AM.



I thought I had included this code already but I'd missed it out. One of the
disadvantages of attrs is that all the keys are unicode strings on py3, but we
need them to be byte strings.

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Oct 12 2019, 9:45 AM

I'd missed out the attrs key conversion needed on py3.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.