This is an archive of the discontinued Mercurial Phabricator instance.

phabricator: add the uploadfile function

Authored by Kwan on Oct 10 2019, 5:52 PM.



This is needed to be able to submit binary files such as images in commits (and
also non-UTF-8 text files). One of the primary disadvantages of the current
use of createrawdiff is that Phabricator simply drops any binary diffs included
in the patch, but not the files, so if such a diff is then committed it
corrupts any binary files in it.

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Oct 10 2019, 5:52 PM
Kwan updated this revision to Diff 17078.Oct 11 2019, 1:54 PM

Fix some test-check-code issues, and one test-check-pyflakes unused local.

indygreg accepted this revision.Oct 11 2019, 9:49 PM
This revision is now accepted and ready to land.Oct 11 2019, 9:49 PM
This revision was automatically updated to reflect the committed changes.