This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7137

largefiles: reset "lfstatus" attribute to previous value in "finally"
ClosedPublic

Authored by martinvonz on Oct 18 2019, 8:51 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG013637f4812e: largefiles: reset "lfstatus" attribute to previous value in "finally"
Summary

We were resetting it to False, which means nesting of these overrides
would be incorrect.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Oct 18 2019, 8:51 PM
martinvonz added a commit: rHG013637f4812e: largefiles: reset "lfstatus" attribute to previous value in "finally".Oct 19 2019, 1:13 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG013637f4812e: largefiles: reset "lfstatus" attribute to previous value in "finally" (authored by martinvonz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/largefiles/overrides.py (3 lines)

Diff 17349

hgext/largefiles/overrides.py

] ]
added = [f for f in lfnames if f not in bad] added = [f for f in lfnames if f not in bad]
return added, bad return added, bad
@contextlib.contextmanager @contextlib.contextmanager
def lfstatus(repo): def lfstatus(repo):
oldvalue = getattr(repo, 'lfstatus', False)
repo.lfstatus = True repo.lfstatus = True
try: try:
yield yield
finally: finally:
repo.lfstatus = False repo.lfstatus = oldvalue
def removelargefiles(ui, repo, isaddremove, matcher, uipathfn, dryrun, **opts): def removelargefiles(ui, repo, isaddremove, matcher, uipathfn, dryrun, **opts):
after = opts.get(r'after') after = opts.get(r'after')
m = composelargefilematcher(matcher, repo[None].manifest()) m = composelargefilematcher(matcher, repo[None].manifest())
with lfstatus(repo): with lfstatus(repo):
s = repo.status(match=m, clean=not isaddremove) s = repo.status(match=m, clean=not isaddremove)
manifest = repo[None].manifest() manifest = repo[None].manifest()