This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7164

packaging: install hgk as hgk.tcl
ClosedPublic

Authored by indygreg on Oct 23 2019, 9:54 PM.

Download Raw Diff

Details

Reviewers

None

Group Reviewers

hg-reviewers

Commits

rHGea5e7726fee0: packaging: install hgk as hgk.tcl
rHG9f5eba23495f: packaging: install hgk as hgk.tcl

Summary

Giving it a file extension will give Windows a better chance
at being able to execute it via standard means. This also
makes WiX consistent with the Inno installer.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 23 2019, 9:54 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptOct 23 2019, 9:54 PM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

indygreg added a child revision: D7165: packaging: stop installing i18n files.Oct 23 2019, 9:54 PM

indygreg added a commit: rHG9f5eba23495f: packaging: install hgk as hgk.tcl.Nov 8 2019, 7:05 PM

This revision was not accepted when it landed; it landed in state Needs Review.

Closed by commit rHG9f5eba23495f: packaging: install hgk as hgk.tcl (authored by indygreg). · Explain Why

This revision was automatically updated to reflect the committed changes.

indygreg added a commit: rHGea5e7726fee0: packaging: install hgk as hgk.tcl.Nov 10 2019, 10:37 AM

Revision Contents
Changeset List

			Path	Packages
M			contrib/packaging/wix/contrib.wxs (2 lines)

Status	Author	Revision
Closed	indygreg	D7173 packaging: stage files and dynamically generate WiX installer
Closed	indygreg	D7172 packaging: use lower case for RC files
Closed	indygreg	D7171 packaging: write out editor.rc in Python
Closed	indygreg	D7170 packaging: stop installing Contributors.txt
Closed	indygreg	D7169 packaging: remove hg-ssh.8.html from Inno installer
Closed	indygreg	D7168 packaging: install .rc files to hgrc.d
Closed	indygreg	D7167 packaging: install contrib/mq.el on WiX
Closed	indygreg	D7166 packaging: ship all help .txt files on WiX
Closed	indygreg	D7165 packaging: stop installing i18n files
Closed	indygreg	D7164 packaging: install hgk as hgk.tcl
Closed	indygreg	D7163 packaging: add logo-droplets.svg
Closed	indygreg	D7162 packaging: install documentation to doc/ directory
Closed	indygreg	D7161 packaging: always pass VERSION into Inno invocation
Closed	indygreg	D7160 packaging: remove hg.exe.local file
Closed	indygreg	D7159 packaging: stage installed files for Inno
Closed	indygreg	D7158 packaging: process Inno Setup files with Jinja2
Closed	indygreg	D7157 packaging: install and run Inno files in a build directory
Closed	indygreg	D7156 packaging: consolidate CLI functionality into packaging.py
Closed	indygreg	D7155 packaging: clean up excess packages for Inno
Abandoned	indygreg	D7154 tests: run black on run-tests.py

Diff 17816

contrib/packaging/wix/contrib.wxs

	</ComponentGroup>			</ComponentGroup>
	</Fragment>			</Fragment>

	<Fragment>			<Fragment>
	<DirectoryRef Id="INSTALLDIR">			<DirectoryRef Id="INSTALLDIR">
	<Directory Id="contribdir" Name="contrib" FileSource="$(var.SourceDir)">			<Directory Id="contribdir" Name="contrib" FileSource="$(var.SourceDir)">
	<Component Id="contrib" Guid="$(var.contrib.guid)" Win64='$(var.IsX64)'>			<Component Id="contrib" Guid="$(var.contrib.guid)" Win64='$(var.IsX64)'>
	<File Name="bash_completion" KeyPath="yes" />			<File Name="bash_completion" KeyPath="yes" />
	<File Name="hgk" />			<File Name="hgk.tcl" Source="$(var.SourceDir)/hgk" />
	<File Name="hgweb.fcgi" />			<File Name="hgweb.fcgi" />
	<File Name="hgweb.wsgi" />			<File Name="hgweb.wsgi" />
	<File Name="logo-droplets.svg" />			<File Name="logo-droplets.svg" />
	<File Name="mercurial.el" />			<File Name="mercurial.el" />
	<File Name="tcsh_completion" />			<File Name="tcsh_completion" />
	<File Name="tcsh_completion_build.sh" />			<File Name="tcsh_completion_build.sh" />
	<File Name="xml.rnc" />			<File Name="xml.rnc" />
	<File Name="zsh_completion" />			<File Name="zsh_completion" />

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	17385		Oct 23 2019, 9:54 PM	★	★
Diff 2	17816	rHG9f5eba23495f235d975422e7de69b698de14d33c	Oct 23 2019, 2:54 PM	★	★