This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7174

largefiles: delete obsolete and unushed repo.push()
ClosedPublic

Authored by martinvonz on Oct 24 2019, 2:38 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG0371a8c84827: largefiles: delete obsolete and unused repo.push()
rHGfb5c72501de2: largefiles: delete obsolete and unushed repo.push()
Summary

The function was removed from localrepo in 4d52e6eb98ea (locarepo:
remove the push method (API), 2014-09-25).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Oct 24 2019, 2:38 PM
indygreg accepted this revision.Oct 24 2019, 11:35 PM
This revision is now accepted and ready to land.Oct 24 2019, 11:35 PM
martinvonz added a commit: rHGfb5c72501de2: largefiles: delete obsolete and unushed repo.push().Oct 24 2019, 11:38 PM
Closed by commit rHGfb5c72501de2: largefiles: delete obsolete and unushed repo.push() (authored by martinvonz). · Explain Why
This revision was automatically updated to reflect the committed changes.
martinvonz added a comment.Nov 5 2019, 4:18 PM

I'll fix the "unushed" typo in flight (there's just one commit on top right now)

Revision Contents
Changeset List

PathPackages
Mhgext/largefiles/reposetup.py (14 lines)

Diff 17407

hgext/largefiles/reposetup.py

date=date, date=date,
match=match, match=match,
force=force, force=force,
editor=editor, editor=editor,
extra=extra, extra=extra,
) )
return result return result
def push(self, remote, force=False, revs=None, newbranch=False):
if remote.local():
missing = set(self.requirements) - remote.local().supported
if missing:
msg = _(
b"required features are not"
b" supported in the destination:"
b" %s"
) % (b', '.join(sorted(missing)))
raise error.Abort(msg)
return super(lfilesrepo, self).push(
remote, force=force, revs=revs, newbranch=newbranch
)
# TODO: _subdirlfs should be moved into "lfutil.py", because # TODO: _subdirlfs should be moved into "lfutil.py", because
# it is referred only from "lfutil.updatestandinsbymatch" # it is referred only from "lfutil.updatestandinsbymatch"
def _subdirlfs(self, files, lfiles): def _subdirlfs(self, files, lfiles):
''' '''
Adjust matched file list Adjust matched file list
If we pass a directory to commit whose only committable files If we pass a directory to commit whose only committable files
are largefiles, the core commit code aborts before finding are largefiles, the core commit code aborts before finding
the largefiles. the largefiles.