This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7363

py3: avoid `b'%s' % type(...)` in a ProgrammingError
ClosedPublic

Authored by martinvonz on Nov 8 2019, 1:20 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGbf87f5ff2ebf: py3: avoid `b'%s' % type(...)` in a ProgrammingError

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Nov 8 2019, 1:20 PM
pulkit accepted this revision.Nov 11 2019, 7:43 AM
This revision is now accepted and ready to land.Nov 11 2019, 7:43 AM
martinvonz added a commit: rHGbf87f5ff2ebf: py3: avoid `b'%s' % type(...)` in a ProgrammingError.Nov 11 2019, 8:26 AM
Closed by commit rHGbf87f5ff2ebf: py3: avoid `b'%s' % type(...)` in a ProgrammingError (authored by martinvonz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (2 lines)

Diff 18015

mercurial/localrepo.py

raise raise
elif len(changeid) == 40: elif len(changeid) == 40:
node = bin(changeid) node = bin(changeid)
rev = self.changelog.rev(node) rev = self.changelog.rev(node)
else: else:
raise error.ProgrammingError( raise error.ProgrammingError(
b"unsupported changeid '%s' of type %s" b"unsupported changeid '%s' of type %s"
% (changeid, type(changeid)) % (changeid, pycompat.sysstr(type(changeid)))
) )
return context.changectx(self, rev, node) return context.changectx(self, rev, node)
except (error.FilteredIndexError, error.FilteredLookupError): except (error.FilteredIndexError, error.FilteredLookupError):
raise error.FilteredRepoLookupError( raise error.FilteredRepoLookupError(
_(b"filtered revision '%s'") % pycompat.bytestr(changeid) _(b"filtered revision '%s'") % pycompat.bytestr(changeid)
) )