This is an archive of the discontinued Mercurial Phabricator instance.

commands: log --line-range is incompatible with --copies
AbandonedPublic

Authored by durin42 on Nov 13 2019, 10:50 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

This was (to my surprise) detected by pytype.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Nov 13 2019, 10:50 PM
dlax added a subscriber: dlax.EditedNov 14 2019, 3:51 AM

Nice pytype catch!

That's a bug, I think. logcmdutil.getlinerangerevs() should return revs as a smartset, not as list. I sent a fix.

durin42 abandoned this revision.Nov 14 2019, 4:17 PM

@dlax seems to have fixed the underlying issue here. :)