( )⚙ D7541 mail: use procutil.shellsplit instead of bytes.split to parse command

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7541

mail: use procutil.shellsplit instead of bytes.split to parse command
ClosedPublic

Authored by jcristau on Dec 2 2019, 8:51 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG8f26dd09aa78: mail: use procutil.shellsplit instead of bytes.split to parse command

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/mail.py (2 lines)

Diff 18576

mercurial/mail.py

ui.note(_(b'sending mail: %s\n') % cmdline) ui.note(_(b'sending mail: %s\n') % cmdline)
fp = procutil.popen(cmdline, b'wb') fp = procutil.popen(cmdline, b'wb')
fp.write(util.tonativeeol(msg)) fp.write(util.tonativeeol(msg))
ret = fp.close() ret = fp.close()
if ret: if ret:
raise error.Abort( raise error.Abort(
b'%s %s' b'%s %s'
% ( % (
os.path.basename(program.split(None, 1)[0]), os.path.basename(procutil.shellsplit(program)[0]),
procutil.explainexit(ret), procutil.explainexit(ret),
) )
) )
def _mbox(mbox, sender, recipients, msg): def _mbox(mbox, sender, recipients, msg):
'''write mails to mbox''' '''write mails to mbox'''
fp = open(mbox, b'ab+') fp = open(mbox, b'ab+')