This is an archive of the discontinued Mercurial Phabricator instance.

tests-pure: fixing test-parseindex2
ClosedPublic

Authored by gracinet on Dec 20 2019, 11:26 AM.

Details

Summary

This is a followup to D7603 (49fa0b31ee1d) which broke
the tests for pure Python implementation. There are two
divergences between pure and C implementations:

  • the pure implementation would accept only -1 as slice end, whereas C accepts both -1 and len(index)
  • in pure Python, headrevs is provided by revlog.py, not by the index.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

gracinet created this revision.Dec 20 2019, 11:26 AM

This seems to be a duplicate of D7706. Could you abandon one of them?

I'm keeping this one.

First phabsend got interrupted, this one has the proper reference in its description.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.