This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7707

tests-pure: fixing test-parseindex2
ClosedPublic

Authored by gracinet on Dec 20 2019, 11:26 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGac627ed8a911: tests-pure: fixing test-parseindex2
Summary

This is a followup to D7603 (49fa0b31ee1d) which broke
the tests for pure Python implementation. There are two
divergences between pure and C implementations:

  • the pure implementation would accept only -1 as slice end, whereas C accepts both -1 and len(index)
  • in pure Python, headrevs is provided by revlog.py, not by the index.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

gracinet created this revision.Dec 20 2019, 11:26 AM
martinvonz added a subscriber: martinvonz.Dec 20 2019, 12:48 PM

This seems to be a duplicate of D7706. Could you abandon one of them?

gracinet added a comment.Dec 20 2019, 1:59 PM

I'm keeping this one.

First phabsend got interrupted, this one has the proper reference in its description.

gracinet added a commit: rHGac627ed8a911: tests-pure: fixing test-parseindex2.Dec 20 2019, 4:12 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGac627ed8a911: tests-pure: fixing test-parseindex2 (authored by gracinet). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-parseindex2.py (6 lines)

Diff 18900

tests/test-parseindex2.py

node = hexrev(p1) + hexrev(p2) + b'.' * 12 node = hexrev(p1) + hexrev(p2) + b'.' * 12
index.append((0, 0, 12, 1, 34, p1, p2, node)) index.append((0, 0, 12, 1, 34, p1, p2, node))
appendrev(4) appendrev(4)
appendrev(5) appendrev(5)
appendrev(6) appendrev(6)
self.assertEqual(len(index), 7) self.assertEqual(len(index), 7)
del index[1:7] del index[1:-1]
# assertions that failed before correction # assertions that failed before correction
self.assertEqual(len(index), 1) # was 4 self.assertEqual(len(index), 1) # was 4
headrevs = getattr(index, 'headrevs', None)
if headrevs is not None: # not implemented in pure
self.assertEqual(index.headrevs(), [0]) # gave ValueError self.assertEqual(index.headrevs(), [0]) # gave ValueError
if __name__ == '__main__': if __name__ == '__main__':
import silenttestrunner import silenttestrunner
silenttestrunner.main(__name__) silenttestrunner.main(__name__)