This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7769

tests: fix a copy/paste name duplication in storage.py
ClosedPublic

Authored by mharbison72 on Dec 28 2019, 11:42 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGa1ee825fc6c5: tests: fix a copy/paste name duplication in storage.py
Summary

Flagged by PyCharm as a redeclared name without usage, because the name matches
the function immediately preceding it. But since this differs by doing regular
reads instead of raw reads, I assume we still want it. But I don't see either
function being called anywhere.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 28 2019, 11:42 AM
mharbison72 added a commit: rHGa1ee825fc6c5: tests: fix a copy/paste name duplication in storage.py.Jan 8 2020, 2:50 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGa1ee825fc6c5: tests: fix a copy/paste name duplication in storage.py (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 19098

mercurial/testing/storage.py

) )
with self.assertRaises(error.StorageError): with self.assertRaises(error.StorageError):
f.rawdata(node1) f.rawdata(node1)
with self.assertRaises(error.StorageError): with self.assertRaises(error.StorageError):
f.rawdata(node1) f.rawdata(node1)
def testbadnoderevisionraw(self): def testbadnoderevision(self):
# Like above except we test read() first to isolate revision caching # Like above except we test read() first to isolate revision caching
# behavior. # behavior.
f = self._makefilefn() f = self._makefilefn()
fulltext0 = b'foo\n' * 30 fulltext0 = b'foo\n' * 30
fulltext1 = fulltext0 + b'bar\n' fulltext1 = fulltext0 + b'bar\n'
with self._maketransactionfn() as tr: with self._maketransactionfn() as tr: