This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7820

grep: speed up `hg grep --all-files some/path` by using ctx.matches(match)
ClosedPublic

Authored by martinvonz on Jan 10 2020, 1:41 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG6cfaebb625d3: grep: speed up `hg grep --all-files some/path` by using ctx.matches(match)
Summary

ctx.matches(match) avoids walking unintersting parts of the tree when
using tree manifests. That can make a very big difference when
grepping in a small subset of the tree (2.0s -> 0.7s in my case, but
can of course be made more extreme by picking a smaller subset of
files).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jan 10 2020, 1:41 PM
pulkit accepted this revision.Jan 13 2020, 7:31 AM
This revision is now accepted and ready to land.Jan 13 2020, 7:31 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/cmdutil.py (14 lines)

Diff 19160

mercurial/cmdutil.py

nrevs.append(rev) nrevs.append(rev)
for rev in sorted(nrevs): for rev in sorted(nrevs):
fns = fncache.get(rev) fns = fncache.get(rev)
ctx = change(rev) ctx = change(rev)
if not fns: if not fns:
def fns_generator(): def fns_generator():
if allfiles: if allfiles:
fiter = iter(ctx)
def bad(f, msg):
pass
for f in ctx.matches(matchmod.badmatch(match, bad)):
yield f
else: else:
fiter = ctx.files() for f in ctx.files():
for f in fiter:
if match(f): if match(f):
yield f yield f
fns = fns_generator() fns = fns_generator()
prepare(ctx, fns) prepare(ctx, fns)
for rev in nrevs: for rev in nrevs:
yield change(rev) yield change(rev)
if stopiteration: if stopiteration:
break break